-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): EdDSA sig verification #1313
Conversation
I implemented the to_bits for any field in PR #1343, could you compare the cost between your noir implementation vs the PR? |
I'm getting a
Line 50 in a04e78a
|
I don't think it is related to the to_bits, I checked the to_bits used and they produce the same version with the noir implementation and with my changes. UPDATE: Using the ex you provided, I was able to see the issue and it is fixed |
Thanks, everything seems to work now and total constraints are back to ~145k compared to ~247k constraints in #1312 (comment) |
- lift baby jubjub into const - EdDSA integration test - lt_bytes32
@kevaundray This should be good for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My points have been addressed so for me this is OK to go, but I let final approval to Kev as I did not review the cryptography part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question re commented out code
* phated/acvm-0.12.0: fix compilation issue switch to published acvm and backend feat(nargo): Consume CommonReferenceString functions & manage caching (#1348) fix(stdlib): Workaround for Field comparison error in EdDSA signature verification (#1372) feat!: remove concept of noir fallbacks for foreign functions (#1371) feat(ssa refactor): mem2reg opt pass (#1363) feat(stdlib): EdDSA sig verification (#1313)
Related issue(s)
Resolves #1109
Supercedes #1136
Depends on #1312, #1343
Description
Summary of changes
eddsa::eddsa_poseidon_verify
function to stdlibstd::ec
functions to use builtinto_bits
std::compat
with ais_bn254
functionDependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context