Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove concept of noir fallbacks for foreign functions #1371

Merged
merged 1 commit into from
May 18, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Removes blocker for #1102

Description

Summary of changes

This PR removes the concept of fallback functions inside the stdlib instead the blackbox function opcodes will always be generated.

This can be reintroduced in future using some form of #1258 (comment) or alternatively a fallback can be implemented inside ACVM.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue May 18, 2023
Merged via the queue into master with commit dbec6f2 May 18, 2023
@kevaundray kevaundray deleted the remove-fallbacks branch May 18, 2023 19:58
TomAFrench added a commit that referenced this pull request May 23, 2023
* phated/acvm-0.12.0:
  fix compilation issue
  switch to published acvm and backend
  feat(nargo): Consume CommonReferenceString functions & manage caching (#1348)
  fix(stdlib): Workaround for Field comparison error in EdDSA signature verification (#1372)
  feat!: remove concept of noir fallbacks for foreign functions (#1371)
  feat(ssa refactor): mem2reg opt pass (#1363)
  feat(stdlib): EdDSA sig verification (#1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants