chore: Add Spell Checker to recommended VS Code extensions #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Oct 12, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 13, 2023
* master: chore: Add Spell Checker to recommended VS Code extensions (#3136) chore: run `nargo fmt` on integration tests (#3059) feat(traits): allow multiple traits to share the same associated function name and to be implemented for the same type (#3126) chore(fmt): format parentheses expression (#3132) chore(fmt): restore removed comment (#3129)
TomAFrench
added a commit
that referenced
this pull request
Oct 13, 2023
* master: chore: apply spellcheck (#3143) feat: Add experimental REPL-based debugger (#2995) fix: do not perform dead instruction elimination on mod,div unless rhs is constant (#3141) chore: allow dependencies with the boost source license (BSL-1.0) (#3142) feat: Reuse witnesses which have been assigned constant values during ACIR gen (#3137) chore: Add Spell Checker to recommended VS Code extensions (#3136) chore: run `nargo fmt` on integration tests (#3059) feat(traits): allow multiple traits to share the same associated function name and to be implemented for the same type (#3126)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
The Noir repo does not currently enforce any spell checks, which could lead to:
Summary*
This PR doesn't enforce a spell check, but adds Code Spell Checker as a recommended VS Code extension for users building in this repo.
Further spell alignments can then be made and enforced more easily through the shared config file cspell.json of this repo.
Additional Context
Referenced AztecProtocol/aztec-packages#2817.
PR Checklist*
cargo fmton default settings.