chore: run nargo fmt on integration tests
#3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/format-integration-tests-2
branch
from
d42e307
to
7d401c8
Compare
TomAFrench
force-pushed
the
tf/format-integration-tests-2
branch
from
7d401c8
to
8e5667e
Compare
Co-authored-by: Koby Hall <[email protected]>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: Koby <[email protected]>
Co-authored-by: kevaundray <[email protected]>
Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com>
Co-authored-by: kevaundray <[email protected]>
…2872) Co-authored-by: Tom French <[email protected]> Co-authored-by: kevaundray <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: kevaundray <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
* master: (29 commits) fix: minor problems with `aztec` publishing (#3095) chore: clean up JS dependencies (#3114) chore: add call formatter (#3102) chore: remove unnecessary clone when executing brillig (#3120) feat: return compilation errors from noir_wasm (#3091) feat: Save Brillig execution state in ACVM (#3026) chore: add method call formatter (#3106) feat!: Pass ACIR to ACVM by reference rather than passing ownership (#2872) chore: add member access formatter (#3109) fix: Determinism of fallback transformer (#3100) chore: clippy (#3108) feat: adding destroy and options object (#3105) chore: standardize witness map serialization format in JS (#3104) chore: add support for index expressions in formatter (#3069) feat: Implement impl specialization (#3087) chore: Update ACIR artifacts (#3086) feat: Implement automatic dereferencing for indexing lvalues (#3083) fix: disallow returning constant values (#2978) feat: Implement automatic dereferencing for index expressions (#3082) feat: add `execute` method to `Noir` class (#3081) ...
kevaundray
approved these changes
Oct 12, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 13, 2023
* master: chore: Add Spell Checker to recommended VS Code extensions (#3136) chore: run `nargo fmt` on integration tests (#3059) feat(traits): allow multiple traits to share the same associated function name and to be implemented for the same type (#3126) chore(fmt): format parentheses expression (#3132) chore(fmt): restore removed comment (#3129)
TomAFrench
added a commit
that referenced
this pull request
Oct 13, 2023
* master: chore: apply spellcheck (#3143) feat: Add experimental REPL-based debugger (#2995) fix: do not perform dead instruction elimination on mod,div unless rhs is constant (#3141) chore: allow dependencies with the boost source license (BSL-1.0) (#3142) feat: Reuse witnesses which have been assigned constant values during ACIR gen (#3137) chore: Add Spell Checker to recommended VS Code extensions (#3136) chore: run `nargo fmt` on integration tests (#3059) feat(traits): allow multiple traits to share the same associated function name and to be implemented for the same type (#3126)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Co-authored-by: Koby Hall <[email protected]> Co-authored-by: kevaundray <[email protected]> Co-authored-by: github-merge-queue[bot] <github-merge-queue[bot]@users.noreply.github.com> Co-authored-by: jfecher <[email protected]> Co-authored-by: Alex Gherghisan <[email protected]> Co-authored-by: Koby <[email protected]> Co-authored-by: guipublic <[email protected]> Co-authored-by: Jonathan Bursztyn <[email protected]> Co-authored-by: José Pedro Sousa <[email protected]> Co-authored-by: Álvaro Rodríguez <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Gustavo Giráldez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR runs some simple formatting on the integration tests so that as we add more features the formatter, we can run it over the integration tests to display the changes made without having a lot of unrelated changes made also.
I've gone through and reverted any unwanted changes as seen in #3002
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.