chore(ci): deduplicate javascript testing workflows #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged in the integration tests into the main javascript testing flow. I've removed the nightly trigger as we run this on every pull request so it shouldn't be necessary. |
|
@kevaundray This is gonna require a bunch of changes for required workflow settings. Edit: I've added a new job which relies on all of the javascript test jobs so we can just make that one required rather than playing whackamole. |
|
New layout is as shown. |
kevaundray
approved these changes
Nov 28, 2023
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2023
* master: (65 commits) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) fix: use 128 bits for constant bit shift (#3586) ...
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2023
* master: (47 commits) chore(docs): Links to Aztec docs from errors (#3423) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR merges all of the javascript workflows into a single workflow so we can reuse the build artifacts for ABI, ACVM and compiler
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.