Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): correct typo in poseidon_hash example in standard_library #3608

Merged
merged 2 commits into from
Nov 28, 2023
Merged

chore(docs): correct typo in poseidon_hash example in standard_library #3608

merged 2 commits into from
Nov 28, 2023

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Nov 28, 2023

Description

Problem*

Resolves #3337

Summary*

This PR modifies hash1 for hash2 to make examples consistent.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TAdev0 TAdev0 changed the title docs : correction of Inconsistency in poseidon hash in standard_library chore: correction of Inconsistency in poseidon hash in standard_library Nov 28, 2023
@kevaundray kevaundray changed the title chore: correction of Inconsistency in poseidon hash in standard_library chore(docs): correct Inconsistency in poseidon hash in standard_library Nov 28, 2023
@kevaundray kevaundray changed the title chore(docs): correct Inconsistency in poseidon hash in standard_library chore(docs): correct typo in poseidon hash example in standard_library Nov 28, 2023
@TAdev0 TAdev0 changed the title chore(docs): correct typo in poseidon hash example in standard_library chore(docs): correction of inconsistency in poseidon hash in standard_library Nov 28, 2023
@TAdev0
Copy link
Contributor Author

TAdev0 commented Nov 28, 2023 •
edited
Loading

@kevaundray sorry i think i modified the title a few seconds after you.

@kevaundray kevaundray changed the title chore(docs): correction of inconsistency in poseidon hash in standard_library chore(docs): correct typo in poseidon_hash example in standard_library Nov 28, 2023
@kevaundray
Copy link
Contributor

@kevaundray sorry i think i modified the title a few seconds after your

No worries!

@kevaundray kevaundray added this pull request to the merge queue Nov 28, 2023
Merged via the queue into noir-lang:master with commit cc041fe Nov 28, 2023
32 of 33 checks passed
TomAFrench added a commit that referenced this pull request Nov 28, 2023
@TomAFrench
Merge branch 'master' into aztec-error-links
96db06e 
* master: (65 commits)
  chore: nargo fmt (#3612)
  fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605)
  chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608)
  feat: aztec-packages (#3599)
  chore: update code formatting to prevent parameter line wrapping (#3588)
  chore: Update ACIR artifacts (#3597)
  chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578)
  chore(ci): deduplicate javascript testing workflows (#3563)
  chore: Release Noir(0.19.4) (#3548)
  chore: update barretenberg to 0.16.0 (#3598)
  chore: move suite of test programs up to repository root (#3485)
  feat: send and receive unflattened public inputs to backend (#3543)
  feat: remove type arrays for flat slices (#3466)
  chore: clippy fix (#3561)
  chore: fix wrapping issue for constraints (#3590)
  feat: add support for tuple values in `noir_codegen` (#3592)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  fix: use 128 bits for constant bit shift (#3586)
  ...
TomAFrench added a commit that referenced this pull request Nov 28, 2023
@TomAFrench
Merge branch 'master' into kw/add-package-version
0eb2c3c 
* master: (47 commits)
  chore(docs): Links to Aztec docs from errors (#3423)
  chore: nargo fmt (#3612)
  fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605)
  chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608)
  feat: aztec-packages (#3599)
  chore: update code formatting to prevent parameter line wrapping (#3588)
  chore: Update ACIR artifacts (#3597)
  chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578)
  chore(ci): deduplicate javascript testing workflows (#3563)
  chore: Release Noir(0.19.4) (#3548)
  chore: update barretenberg to 0.16.0 (#3598)
  chore: move suite of test programs up to repository root (#3485)
  feat: send and receive unflattened public inputs to backend (#3543)
  feat: remove type arrays for flat slices (#3466)
  chore: clippy fix (#3561)
  chore: fix wrapping issue for constraints (#3590)
  feat: add support for tuple values in `noir_codegen` (#3592)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in poseidon hash in Noir documentation
2 participants
@TAdev0 @kevaundray