Support new selected and inactive tab highlighting editor scheme keys #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selected and inactive tabs were previously styled using the corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are now deprecated or marked as "unknown" to the UI theme scheme validator. The highlighting is now controlled using the new `TAB_SELECTED` and `TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE platform code in JetBrains/intellij-community@bf26eb8. In my opinion there are some keys that should not be placed in the editor scheme (including these both) and it feels like there is inconsistency between the UI theme API and editor color scheme API. Anyway, in order to style tabs correctly again, both new editor scheme keys have been added using the same colors like the UI theme keys. Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment) Related to GH-120 GH-126
svengreb
approved these changes
Feb 15, 2020
arcticicestudio
deleted the
feature/gh-126-support-tab-selected-inactive-tab
branch
arcticicestudio
added a commit
that referenced
this pull request
Feb 15, 2020
Selected and inactive tabs were previously styled using the corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are now deprecated or marked as "unknown" to the UI theme scheme validator. The highlighting is now controlled using the new `TAB_SELECTED` and `TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE platform code in JetBrains/intellij-community@bf26eb8. In my opinion there are some keys that should not be placed in the editor scheme (including these both) and it feels like there is inconsistency between the UI theme API and editor color scheme API. Anyway, in order to style tabs correctly again, both new editor scheme keys have been added using the same colors like the UI theme keys. Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment) Related to GH-120 Closes GH-126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126
Before
After