Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new selected and inactive tab highlighting editor scheme keys #130

Merged

Commits on Feb 15, 2020

  1. Support new selected and inactive tab highlighting editor scheme keys

    Selected and inactive tabs were previously styled using the
    corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are
    now deprecated or marked as "unknown" to the UI theme scheme validator.
    The highlighting is now controlled using the new `TAB_SELECTED` and
    `TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE
    platform code in JetBrains/intellij-community@bf26eb8.
    
    In my opinion there are some keys that should not be placed in the
    editor scheme (including these both) and it feels like there is
    inconsistency between the UI theme API and editor color scheme API.
    Anyway, in order to style tabs correctly again, both new editor scheme
    keys have been added using the same colors like the UI theme keys.
    
    Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment)
    Related to GH-120
    GH-126
    arcticicestudio committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    bfbbb6c View commit details
    Browse the repository at this point in the history