fix(perf): lazy load glob on normalize.js #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H4ad
force-pushed
the
perf/lazy-load-glob
branch
from
6d6b779
to
6e2e9b8
Compare
|
Note: this |
wraithgar
approved these changes
Apr 10, 2024
wraithgar
pushed a commit
that referenced
this pull request
Apr 10, 2024
Combined with #89, we can reduce the load time of `normalize` to less than `1ms`, making the `run-script` load in `4ms` instead of `13ms`.
Merged
wraithgar
pushed a commit
that referenced
this pull request
Apr 10, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.2](v5.0.1...v5.0.2) (2024-04-10) ### Bug Fixes * [`a67317b`](a67317b) [#90](#90) perf: lazy load hosted git info on normalize (#90) (@H4ad) * [`06df698`](06df698) [#89](#89) perf: lazy load glob on normalize.js (#89) (@H4ad) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since npm run didn't call those steps, we can save some
msby lazy loading this dependency.Before:
After:
The entire load time didn't change, still
13msbefore & after, but if we callnpm runinside a project that didn't have workspaces, we will save somems, like this one:But this will also require the PR npm/cli#7360 to be merged.