Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf): lazy load hosted git info on normalize #90

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(perf): lazy load hosted git info on normalize #90

merged 1 commit into from
Apr 10, 2024

Conversation

H4ad
Copy link
Contributor

@H4ad H4ad commented Apr 10, 2024 •
edited
Loading

Combined with #89, we can reduce the load time of normalize to less than 1ms, making the run-script load in 4ms instead of 13ms.

@H4ad H4ad requested a review from a team as a code owner April 10, 2024 11:46
@H4ad H4ad force-pushed the perf/lazy-load-hosted-git-info branch from 28a9696 to dcf42fc Compare April 10, 2024 11:46
@wraithgar
Copy link
Member

Note: This runs during the bin step which is done to a packument when it's downloaded during the install process. The only packument that's downloaded during npm i -g npm is npm itself, and the entire normalization process will have completed before reification starts.

@wraithgar wraithgar merged commit a67317b into npm:main Apr 10, 2024
21 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Merged
wraithgar pushed a commit that referenced this pull request Apr 10, 2024
@github-actions
chore: release 5.0.2 (#91)
b1e741b 
🤖 I have created a release *beep* *boop*
---


## [5.0.2](v5.0.1...v5.0.2)
(2024-04-10)

### Bug Fixes

*
[`a67317b`](a67317b)
[#90](#90) perf: lazy load
hosted git info on normalize (#90) (@H4ad)
*
[`06df698`](06df698)
[#89](#89) perf: lazy load glob
on normalize.js (#89) (@H4ad)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@H4ad H4ad deleted the perf/lazy-load-hosted-git-info branch April 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H4ad @wraithgar