Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I called the matcher
containsAll
but there are couple problems with this name:IsIterableContainingInAnyOrder
which means "equal iterables ignoring order of elements". It's not the same as equalSet
objects and not the same asCollection.containsAll
.apply
closure, it clashes with built-incontainsAll
function (see https://github.com/dkandalov/hamkrest/blob/c421c419294236336db8000bae1325321889208b/src/test/kotlin/com/natpryce/hamkrest/collection_matchers_tests.kt#L166-L166)I also have doubts that current mismatch description is good. Also passing custom "equality" matcher and nested iterables API looks a bit clunky.