Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine logs for buffer validation in init containers #185

Closed
whynowy opened this issue Sep 27, 2022 · 3 comments
Closed

Refine logs for buffer validation in init containers #185

whynowy opened this issue Sep 27, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for new contributors

Comments

@whynowy
Copy link
Member

whynowy commented Sep 27, 2022

Following log is displayed in the init container which is expected by misleading, need to refine the log.

{""level"":""error"",""ts"":1662516312.3855174,""logger"":""numaflow.isbsvc-buffer-validate"",""caller"":""commands/isbsvc_buffer_validate.go:61"",""msg"":""Buffers validation failed, will retry if the limit is not reached"",""error"":""failed to query information of stream ""ss-osam-mlp-fci-pipeline-dev-devx-osammlpfci-usw2-e2e-ss-osam-mlp-fci-pipeline-numaflowosamrouter-fcipluginappintr-inf"", nats: stream not found"","
@whynowy whynowy added bug Something isn't working good first issue Good for new contributors labels Sep 27, 2022
@whynowy whynowy changed the title Log refine for buffer validation in init containers Refine logs for buffer validation in init containers Sep 27, 2022
@shadowshot-x
Copy link

I can work on this issue @whynowy. It will help me verse myself with the repository a bit.

@vigith
Copy link
Member

vigith commented Oct 3, 2022

@shadowshot-x it is yours 😄

@juliev0
Copy link
Contributor

juliev0 commented Feb 16, 2023

@shadowshot-x are you working on this?

dpadhiar added a commit to dpadhiar/numaflow that referenced this issue Feb 28, 2023
@dpadhiar
fix: refine log for buffer validation. Fixes numaproj#185
af59356 
Signed-off-by: Dillen Padhiar <[email protected]>
whynowy pushed a commit that referenced this issue Mar 13, 2023
@dpadhiar @whynowy
fix: refine log for buffer validation. Fixes #185 (#573)
b14d470 
Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vigith @whynowy @juliev0 @shadowshot-x