fix: refine log for buffer validation. Fixes #185 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dillen Padhiar <[email protected]>
whynowy
reviewed
Feb 28, 2023
| @@ -74,7 +74,7 @@ func NewISBSvcBufferValidateCommand() *cobra.Command { | |||
| } | |||
| _ = wait.ExponentialBackoffWithContext(ctx, sharedutil.DefaultRetryBackoff, func() (bool, error) { | |||
| if err = isbsClient.ValidateBuffers(ctx, bfs); err != nil { | |||
| logger.Errorw("Buffers validation failed, will retry if the limit is not reached", zap.Error(err)) | |||
| logger.Errorw("Buffers not created yet, will retry if the limit is not reached", zap.Error(err)) | |||
There was a problem hiding this comment.
- Maybe using
Infois better? Buffers might have not been created yet, xxxx
Signed-off-by: Dillen Padhiar <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log statement for buffer validation previously was misleading. This validation occurs in the vertex pod's init container. When the vertex pod is being created, this validation happens while the buffers are still being created thus making this log inaccurate.
New log statement shows that the buffers likely aren't created yet instead of an error.