apply all formatters even when there's errors #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmcgee
force-pushed
the
feat/apply-all-formatters-on-error
branch
from
8a69906
to
0f3f314
Compare
If a formatter errors out, continue with subsequent formatters regardless. Do not cache the result to ensure later invocations re-try the same files. Signed-off-by: Brian McGee <[email protected]>
brianmcgee
force-pushed
the
feat/apply-all-formatters-on-error
branch
from
0f3f314
to
b834fa3
Compare
brianmcgee
changed the title
zimbatm
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying a sequence of formatters, continue applying the batch to successive formatters even if one of the stages fails.
Closes #316