fix: do not cache formatting errors #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
approved these changes
Oct 14, 2024
brianmcgee
force-pushed
the
fix/no-cache-errors
branch
2 times, most recently
from
dbda676
to
5814173
Compare
jfly
approved these changes
Oct 14, 2024
This was a regression introduced when the new `walk.Reader` approach was applied. When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations. I've extended the `walk.ReleaseFunc` to accept an optional `error` which can be used to indicate the file participated in a batch that had errors when being formatted. This allows the hook implementation to decide what it should do. Closes #449 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
force-pushed
the
fix/no-cache-errors
branch
from
5814173
to
4f1f3d6
Compare
brianmcgee
added a commit
that referenced
this pull request
Oct 15, 2024
We try to apply formatters to all files on a best-effort basis, continuing if formatting any particular batch of files fails. This fix ensures that if any formatting errors occur, the process will exit with an error. Closes #450 Signed-off-by: Brian McGee <[email protected]>
1 task
brianmcgee
added a commit
that referenced
this pull request
Oct 15, 2024
We try to apply formatters to all files on a best-effort basis, continuing if formatting any particular batch of files fails. This fix ensures that if any formatting errors occur, the process will exit with an error. Closes #450 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
that referenced
this pull request
Oct 16, 2024
We try to apply formatters to all files on a best-effort basis, continuing if formatting any particular batch of files fails. This fix ensures that if any formatting errors occur, the process will exit with an error. Closes #450 Signed-off-by: Brian McGee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression introduced when the new
walk.Readerapproach was applied.When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations.
I've extended the
walk.ReleaseFuncto accept an optionalerrorwhich can be used to indicate the file participated in a batch that had errors when being formatted.This allows the hook implementation to decide what it should do.
Closes #449
Signed-off-by: Brian McGee [email protected]