fix: exit with error if any formatters fail #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmcgee
changed the title
brianmcgee
force-pushed
the
fix/exit-with-error-formatters-fail
branch
from
77d8c42
to
d0e10fc
Compare
We try to apply formatters to all files on a best-effort basis, continuing if formatting any particular batch of files fails. This fix ensures that if any formatting errors occur, the process will exit with an error. Closes #450 Signed-off-by: Brian McGee <[email protected]>
Helps with debugging tests. Signed-off-by: Brian McGee <[email protected]>
brianmcgee
force-pushed
the
fix/exit-with-error-formatters-fail
branch
from
2176102
to
39774dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to apply formatters to all files on a best-effort basis, continuing if formatting any particular batch of files fails.
This fix ensures that if any formatting errors occur, the process will exit with an error.
Closes #450
TODO