Recognize .NET 7 when installed #1194
Conversation
| @@ -201,6 +201,8 @@ private Version GetClrVersionForFramework(Version frameworkVersion) | |||
| return new Version(5, 0, 1); | |||
| case 6: | |||
| return new Version(6, 0, 0); | |||
| case 7: | |||
There was a problem hiding this comment.
question, out of curiosity: With the increased release cadence of new versions now compared to the netfx days, is there a benefit (or harm?) of adding a default case like return new Version(frameworkversion.Major, 0, 0)
There was a problem hiding this comment.
@stevenaw Yes, but not worth the effort right here as this method doesn't exist in the 4.0 builds. Once released, 3.15.1 will become my new "final" 3.x release - unless another critical bug shows up! I'll take a look to see if we need something similar in 4.0.
There was a problem hiding this comment.
I have verified that this problem doesn't arise at all in the 4.0 build, which contains no code similar to what I fixed here. The 4.0.0-devxxxxx builds run fine with .NET 7.0 preview 5 installed.
There was a problem hiding this comment.
Thanks @CharliePoole I completely agree and understand about "not right now" 🙂
I'm mostly asking because I've seen a few places where we have this hard-coded version mapping and I wasn't sure if there'd been discussion about it yet, or considered and ruled out for some reason. I didn't realize it had already been adjusted in the 4.0 build.
Fixes #1193