Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment vue rather than @vue/runtime-core #1045

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix: augment vue rather than @vue/runtime-core #1045

merged 3 commits into from
Aug 16, 2024

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In line with vuejs/router#2295 and nuxt/nuxt#28542, this moves to augment vue rather than @vue/runtime core.

This is now officially recommended in the docs and it must be done by all libraries or it will break types for other libraries.

Copy link

netlify bot commented Aug 16, 2024

βœ… Deploy Preview for nuxt-sanity-module canceled.

Name Link
πŸ”¨ Latest commit e4f2e97
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-sanity-module/deploys/66bf39b723b9070008df3dad

@danielroe danielroe changed the title chore: add CODEOWNERS file fix: augment vue rather than @vue/runtime-core Aug 16, 2024
@danielroe danielroe merged commit 9638b18 into main Aug 16, 2024
5 checks passed
@danielroe danielroe deleted the vue-augment branch August 16, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant