Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: router typescript definations related to vue package #2295

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

lovetingyuan
Copy link
Contributor

image
image

after

image
image

I noticed the comment : // TODO: figure out why it cannot be 'vue' like said in docs, actullay, it works in the latest version of vue(3.4.31)

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 97be7c3
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/668ac81eb6ec19000831618c

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This can be changed now indeed. It was already updated in pinia

@posva posva merged commit a495ce0 into vuejs:main Jul 9, 2024
5 checks passed
@ghost
Copy link

ghost commented Aug 1, 2024

@posva This breaks parameter types for in-component navigation guards supplied to defineComponent.
Screenshot 2024-08-01 at 2 12 41 PM

This was referenced Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants