-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Say-all repeats some lines. #11132
Comments
The same can be reproduced when reading pages in Firefox and with emails in HTML format in Thunderbird. |
Hello, one more test case:
|
Hi. NVDA also repeats sentences until a "period" is encountered. For instance, open https://www.zdnet.com/article/i-just-dumped-one-of-apples-worst-most-beautiful-products |
Hi same on my windows 10 64. |
@derekriemer @josephsl Can you reproduce this? |
@tapper82 this issue is reproducible and it is already known. See the PR referenced in the issue description for more details. |
This is getting a bit annoying. @feerrenrut not trying to force you at all, but could a revert be considered if a fix can't be available soon? |
Hi, Seconded - would like to get this done before beta freeze please. Thanks. |
+1 |
Agreed with the other calls to revert this, because it is really quite annoying when using say all. |
Used version: alpha-20317,6bf3ae5f |
This comment has been minimized.
This comment has been minimized.
Apparently fixed in #11245. |
No, I can still duplicate it with Alpha-20317. |
While I agree that this is an annoying issue, Two points:
Comments with a harsh tone of voice like the one written by @tapper82 really aren't helpful in this situation. Please stay kind to each other. |
#11245 is not yet merged... |
Looking forward to it then. |
fixes #11132 - Say-all repeats some lines fixes #11144 - Attempt to cancel speech for expired focus events: dialog title discarded when finding text in browse mode Adds a speechManager test harness Logging: Support writing unit tests by enabling 'IS_UNIT_TEST_LOG_ENABLED'. Logging: Improve repr for _CancellableSpeechCommand, include devInfo for 'isValid' Logging: Help debug double speaking Tests: for double speaking during say-all. Tests: Wrapped index (IndexCommands) comparisons and fixes comparisons Tests: From manual testing during initial development of SpeechManager Tests: Cancellable Speech Fix: double speaking error Fix: sudden silence during cancellable speech error which is broken during "Fix double speaking error" Fix: cancelling speech on index callback Fix: missing speech in run dialog - Speech is valid if ancestor of current focus. - Only ask speechManager to remove cancelled speech after the isValidDeps are updated, specifically lastQueuedFocusObject
Steps to reproduce:
Using
alpha-20175,9967903a
or later.The problem does not require changing the
Attempt to cancel speech for expired focus events
setting.Actual behavior:
After a few lines, the following is read twice:
"Tested moving through emails (and across table boundaries) in Gmail"
Expected behavior:
The line should be read once.
System configuration
NVDA installed/portable/running from source:
Installed.
NVDA version:
Alpha build, post #10885 merge:
alpha-20175,9967903a
Does not repro with prior alpha: alpha-20168,1cf36fbe
Windows version:
Win 10: 1909
Name and version of other software in use when reproducing the issue:
Chrome 81
Other questions
If addons are disabled, is your problem still occuring?
No addons
The text was updated successfully, but these errors were encountered: