Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say-all repeats some lines. #11132

Closed
feerrenrut opened this issue May 8, 2020 · 17 comments · Fixed by #11245
Closed

Say-all repeats some lines. #11132

feerrenrut opened this issue May 8, 2020 · 17 comments · Fixed by #11245
Assignees
@feerrenrut
Labels
bug/regression component/speech p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2020.2

Comments

@feerrenrut
Copy link
Contributor

feerrenrut commented May 8, 2020 •
edited
Loading

Steps to reproduce:

Using alpha-20175,9967903a or later.

  1. Open Cancellable speech #10885 with Chrome
  2. Jump by heading with 'h' until you get to the heading "Description of how this pull request fixes the issue"
  3. Start say-all (NVDA+down arrow)

The problem does not require changing the Attempt to cancel speech for expired focus events setting.

Actual behavior:

After a few lines, the following is read twice:
"Tested moving through emails (and across table boundaries) in Gmail"

Expected behavior:

The line should be read once.

System configuration

NVDA installed/portable/running from source:

Installed.

NVDA version:

Alpha build, post #10885 merge: alpha-20175,9967903a
Does not repro with prior alpha: alpha-20168,1cf36fbe

Windows version:

Win 10: 1909

Name and version of other software in use when reproducing the issue:

Chrome 81

Other questions

If addons are disabled, is your problem still occuring?

No addons
@feerrenrut feerrenrut added component/speech bug/regression p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels May 8, 2020
@feerrenrut feerrenrut self-assigned this May 8, 2020
@feerrenrut feerrenrut mentioned this issue May 8, 2020
Merged
@Mary5958
Copy link
Contributor

Mary5958 commented May 9, 2020

The same can be reproduced when reading pages in Firefox and with emails in HTML format in Thunderbird.

@gregjozk
Copy link
Contributor

Hello,

one more test case:

  • open addons.nvda-project.org
  • choose addon developer toolkit
  • start say all
  • nvda repeats many lines in a list of keyboard shortcuts etc

@Adriani90 Adriani90 mentioned this issue May 13, 2020
Closed
@amirsol81
Copy link

Hi. NVDA also repeats sentences until a "period" is encountered. For instance, open https://www.zdnet.com/article/i-just-dumped-one-of-apples-worst-most-beautiful-products
NVDA repeats many sentences in continuous reading. The first repeated one is "It all must have seemed like a good idea at the time." It is located after the first heading. Simply place the cursor on the heading, or even on the last character of the heading, and press Insert+Down to initiate continuous reading.
This is with NVDA Version alpha-20204,0f54e8ce and Chrome 81/IE 11 on Windows 10 Version 2004.

@tapper82
Copy link

Hi same on my windows 10 64.
NVDA
Version: alpha-20206,dba33431
Firefox 78.1

@tapper82
Copy link

@derekriemer @josephsl Can you reproduce this?

@Adriani90
Copy link
Collaborator

@tapper82 this issue is reproducible and it is already known. See the PR referenced in the issue description for more details.

@LeonarddeR
Copy link
Collaborator

This is getting a bit annoying.

@feerrenrut not trying to force you at all, but could a revert be considered if a fix can't be available soon?

@josephsl
Copy link
Collaborator

Hi,

Seconded - would like to get this done before beta freeze please.

Thanks.

@tapper82
Copy link

+1

@Neurrone
Copy link

Agreed with the other calls to revert this, because it is really quite annoying when using say all.

@feerrenrut feerrenrut mentioned this issue Jun 10, 2020
Merged
This was referenced Jun 10, 2020
Closed
Closed
@dpy013
Copy link
Contributor

dpy013 commented Jun 15, 2020

Used version: alpha-20317,6bf3ae5f
has been tested in Simplified Chinese, the problem has been solved.
testing.log

@tapper82

This comment has been minimized.

Sign in to view
@codeofdusk
Copy link
Contributor

Apparently fixed in #11245.

@amirsol81
Copy link

No, I can still duplicate it with Alpha-20317.

@LeonarddeR
Copy link
Collaborator

While I agree that this is an annoying issue, Two points:

  1. There is an open pr that will solve this, Fix several issues in speech manager #11245

  2. This code is only in Alpha snapshots. Note the following from the development snapshots page:

    Alpha snapshots contain bleeding-edge code. These snapshots are generated straight from NVDA's mainline (master) branch. Once a feature is implemented, it will be merged straight into this branch. Although there are some automated tests, code in this branch may have not been tested at all by users. This should never be used in a production environment!

Comments with a harsh tone of voice like the one written by @tapper82 really aren't helpful in this situation. Please stay kind to each other.

@LeonarddeR
Copy link
Collaborator

#11245 is not yet merged...

@amirsol81
Copy link

Looking forward to it then.

feerrenrut added a commit that referenced this issue Jun 16, 2020
@feerrenrut
Fix several issues in speech manager (PR #11245)
c7a1e08 
fixes #11132 - Say-all repeats some lines
fixes #11144 - Attempt to cancel speech for expired focus events: dialog title discarded when finding text in browse mode

Adds a speechManager test harness
Logging: Support writing unit tests by enabling 'IS_UNIT_TEST_LOG_ENABLED'.
Logging: Improve repr for _CancellableSpeechCommand, include devInfo for 'isValid'
Logging: Help debug double speaking
Tests: for double speaking during say-all.
Tests: Wrapped index (IndexCommands) comparisons and fixes comparisons
Tests: From manual testing during initial development of SpeechManager
Tests: Cancellable Speech
Fix: double speaking error
Fix: sudden silence during cancellable speech error which is broken during "Fix double speaking error"
Fix: cancelling speech on index callback
Fix: missing speech in run dialog
 - Speech is valid if ancestor of current focus.
 - Only ask speechManager to remove cancelled speech after the isValidDeps are updated,
    specifically lastQueuedFocusObject
@nvaccessAuto nvaccessAuto modified the milestone: 2020.2 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feerrenrut feerrenrut

Labels
bug/regression component/speech p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2020.2
Development

Successfully merging a pull request may close this issue.

Fix several issues in speech manager nvaccess/nvda