Attempt to cancel speech for expired focus events: dialog title discarded when finding text in browse mode #11144
Labels
Comments
Merged
feerrenrut
added a commit
that referenced
this issue
Jun 16, 2020
fixes #11132 - Say-all repeats some lines fixes #11144 - Attempt to cancel speech for expired focus events: dialog title discarded when finding text in browse mode Adds a speechManager test harness Logging: Support writing unit tests by enabling 'IS_UNIT_TEST_LOG_ENABLED'. Logging: Improve repr for _CancellableSpeechCommand, include devInfo for 'isValid' Logging: Help debug double speaking Tests: for double speaking during say-all. Tests: Wrapped index (IndexCommands) comparisons and fixes comparisons Tests: From manual testing during initial development of SpeechManager Tests: Cancellable Speech Fix: double speaking error Fix: sudden silence during cancellable speech error which is broken during "Fix double speaking error" Fix: cancelling speech on index callback Fix: missing speech in run dialog - Speech is valid if ancestor of current focus. - Only ask speechManager to remove cancelled speech after the isValidDeps are updated, specifically lastQueuedFocusObject
|
Hi @feerrenrut I'm afraid this issue is not fixed for me with NVDA version alpha-20339,975d39d1 and Firefox Nightly 79 - dialog title is still discarded when it opens. @LeonarddeR Can you confirm? |
|
yes I can still reproduce this with the NVDA find dialog. I was using the run dialog (windows key + r) as an example when attempting to fix this issue. The issue here is that the title does not seem to be a direct focus ancestor of the edit control, at least that is what the "speechManager" debug logging says (enabled via advanced panel). |
|
The run dialog, however, does seem to be fixed. |
|
This should be fixed now, can anyone confirm? |
|
cannot reproduce with NVDA version alpha-21348,6af30832. |
|
Thanks @lukaszgo1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
Actual behavior:
NVDA only announces:
Find dialogis shown by the speech viewer, but it is interrupted immediately.Expected behavior:
NVDA announces:
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
alpha-20175,9967903a
Windows version:
Windows 10 2004 19041.208
Name and version of other software in use when reproducing the issue:
Firefox 76.0.1
Other questions
Does the issue still occur after restarting your computer?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
NO
If addons are disabled, is your problem still occuring?
Yes
Did you try to run the COM registry fixing tool in NVDA menu / tools?
No, n/a
The text was updated successfully, but these errors were encountered: