-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual highlight of focus, browse or caret location being read. #971
Comments
Comment 1 by expressABLE on 2010-10-07 23:06 |
Comment 2 by jteh on 2013-08-27 02:40 |
Comment 3 by nishimotz on 2013-08-27 05:03 My implementation sometimes fail to follow current focus or navigator object, and I think it would be nice to be integrated with core system for further improvements. |
Comment 4 by briang1 on 2013-08-27 07:42 |
Comment 5 by nishimotz on 2013-08-27 07:51 https://bitbucket.org/nishimotz/focushighlight/commits/d30e9de2d58e7e9975122a88403fe7fb1d1287a8 |
Comment 6 by k_kolev1985 on 2013-08-27 08:05 After my e-mail to you from yesterday, I've found another bug. It seams that reading of opened combo-boxes is broken if using the "Focus Highlight" add-on. Examples of such combo-boxes are the ones in NVDA's interface (settings) and the ones for choosing a output file type in a "Save as" dialog (I think - no matter in witch application). Actually, it may as well affect all combo-boxes - I haven't managed to test. |
See also: #6172 |
@feerrenrut: Is there still interest in having this integrated into NVDA core? @nishimotz: I recall having some issues with screen review while using focus highlight, but it could have to do with the fact that I was using an older version. Could you elaborate on the what, the why and the how things have been changed in your add-on since your last comment of around 5 years ago? |
The stateChange and valueChange events, regarding ComboBox windows, are specially handled in current focusHighlight add-on to avoid the issues. Regarding display resolution and multiple monitors, the version 5.0 uses physical coordinates consistently in NVDA, as discussed in #7065. So far, focusHighlight uses its own thread and message loop. Lastly, I have selected the colors of red and green. |
As a matter of interest is there any way to tone down the new versions use
of the nvda log? I'd expect the verbosity in a dev version but the previous
version did not shove all the stuff in the log on debug, and it can make
finding out when an nvda issue is a problem rather harder without turning it
off, which is normally only on when sighted people need to follow what is
going on.
Brian
[email protected]
Sent via blueyonder.
Please address personal E-mail to:-
[email protected], putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Takuya Nishimoto" <[email protected]>
To: "nvaccess/nvda" <[email protected]>
Cc: "Subscribed" <[email protected]>
Sent: Sunday, May 13, 2018 10:03 AM
Subject: Re: [nvaccess/nvda] Visual highlight of focus, browse or caret
location being read. (#971)
… The stateChange and valueChange events, regarding ComboBox windows, are
specially handled in current focusHighlight add-on to avoid the issues.
However, I am not sure it is always safe.
Regarding display resolution and multiple monitors, the version 5.0 uses
physical coordinates consistently in NVDA, as discussed in #7065.
So far, focusHighlight uses its own thread and message loop.
The event mechanism of NVDA can be improved for better implementation.
I cannot remember, but there are discussions regarding this.
Lastly, I have selected the colors of red and green.
It was not the best choice in terms of color universal design, so I am
using dotted lines in addition to colors.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#971 (comment)
|
@nishimotz: Thanks for your information. I also read that you are now using GDI Plus since version 5, but what were you using before? Have you considered using wx to draw the rectangles? That way, you can avoid interfacing with GDI at the library level, and if that works, I'd really prefer that for a core implementation. |
@LeonarddeR before using GDI plus, I have been using legacy Win32 API, such as CreateWindow and FillRect. |
A screen-reader isn't only for the blind and I think that beeing able to see where on the screen focus is should be a part of the core product. It isn't a special feature for a certain application and should therefore qualify as a core feature. |
I think there is some consensus within the developer space that a highlight feature should be part of NVDA core. Therefore I'm marking this as feature. Personally, I'd vote for exploring how we could do this with WXPython, since it is much more pythonic than interfacing with GDI or GDI Plus directly. CC @feerrenrut |
@nishimotz: From what I've seen, I think using wx might be the most elegant way within NVDA's core. Instead of using one window per highlight, have you also considered using only one window that contains the several highlights, thus one transparent window that doesn't have to be repositioned, only cleared and painted again? |
@LeonarddeR I am investigating how to use GDIPlus from wxPython. |
Ok, yet wx it will be. I have a prototype implementation that will be released later this year as part of a bigger vision framework that also adds a screen curtain. |
I am aware that my FocusHighlight add-on doesn't work with NVDA 2018.4 anymore, regarding navigator object within the Web browsers, such as Chrome and Firefox. As far as I have investigated, #8678 is related. New vision framework i.e. PR #9064 snapshot is working regarding this as expected. |
…object and browse mode caret highlighting (PR #9064) Foundations of framework to enable: - #7857: Making the screen black (i.e. a screen curtain) while NVDA is active, mainly for privacy reasons - #971: Visual highlight of focus, review or browse mode caret location - Basic screen magnification facility within NVDA. This pr intends to lay the base of a vision framework that can be used to implement such functionality in the core of NVDA. Though there is no GUI in the current pull request, the framework is functional.
Now that #9064 has been merged, thanks to Leonard, Reef and Takuya for their good work on this, I think the basis for this feature is implemented. I am closing this issue now but please feel free to create new issues or new discussion based on the current implementation on last NVDA Alpha. |
@Adriani90 I think I would prefer to keep this open until the Gui is implemented. While it is possible to enable this at the moment if you make the right changes in the config file, it is not really usable. |
This was exactly why I didn't make the github magic automatically close
this. I will update #10082 accordingly.
|
Reported by expressABLE on 2010-10-07 23:01
NVDA focus, caret or browse location to be visually highlighted on the word, character or other feature of a webpage, menu or document, etc. that is currently being read or focused on.
Other software that has such a feature include Supernova, Zoomtext, Read and Write Gold, Kurzweil, free ReadPlease, and supposedly Apple Voiceover.
As a sighted assistive tech specialist using NVDA the last two years, I believe this would be very helpful for sighted guides teaching NVDA, those with low vision, website developers trying to improve accessibility (without having the time to learn the whole screenreader), and folks with dyslexia and other reading disabilities as well.
This idea received positive response on the NVDA users list.
NVDA is now featured in a learning disabilities software suite called MyStudyBar.
For low vision, it would be great if the highlight could be adjustable in preferences for size, and color, perhaps even changing color for each particular mode. For example: blue with yellow font for browse; light blue with black letters for focus.
Is there already something like this that could work in
conjunction with NVDA?
Thank you for the consideration. I don't know how to program but
would be gung-ho to work with somebody, provide clarification of intent, details or any other field experience feedback.
Thank you.
Sincerely,
Chris Johnson,
Assistive Technology Specialist
The text was updated successfully, but these errors were encountered: