-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a graphical user interface for the vision framework #10082
Conversation
@nishimotz I was thinking about your focus highlight add-on while looking at the changelog entry. Are you intending to discontinue your add-on, or will you rebase it onto the new framework? I think there are still some implementation differences that might cause people to prefer one or the other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your plan for the user guide? Could you update it in this PR, covering the vision panel and focus highlight. Then on the screen curtain PR add that?
I hope you don't mind, I have pushed a commit that addresses a few layout issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do the user guide as part of this. Have two questions about your change
Overall, I am pretty happy with the default colors for focus highlight. But I might adjust them to have some transparency in a later PR. When they are over text, it can obscure adjacent text. |
We should consider people who have difficulty distinguishing between red and green colors. |
Typo: vvision > vision BNrowse mode caret is shown using a rectangle, not a single line
…ning for the screen curtain
@feerrenrut: This is ready for another review. I think everything from 641ccdc is new. |
I'm seeing some unexpected changes in the diff ie libluis. I'll review the user guide to start with. |
Current pr build failed |
@dingpengyu Failed appveyor builds are pretty likely to be acted upon pretty soon after they fail. |
|
I was afraid that the Highlighter could suffer from #10211, that is not being functional while the Windows Magnifier is turned on. |
Note that this gui is still a prototype, it will have a revisit by
@feerrenrut
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi This branch has conflicts that must be resolved
This is a known issue. This work is a continuous work in progress.
It was introduced with this feature, but is not used.
This was introduced with this feature. Not being used by the framework, and seems likely to mislead.
- class AutoSettings - data class ProviderInfo This is more consistent with class DriverSettings It communicates the intended usage of the string better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, thanks @feerrenrut
This work was delivered via commit 46c5606 |
Thank you for beautifully reimplementing my work. |
Browse cursor is the one used in browse mode in the web navigators, PDF
files and so on...
Review cursor is used on object navigation and screen review...
Rui Fontes
Às 06:30 de 24/11/2019, Takuya Nishimoto escreveu:
…
Thank you for beautifully reimplementing my work.
I would like to ask from the translation standpoint.
Is the Browse Mode Cursor and the Review Cursor technically different?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10082?email_source=notifications&email_token=ADZAPRU5BLY4X4D5ART7M5LQVINPTA5CNFSM4ILJQPCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFAEYWA#issuecomment-557861976>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZAPRTMFQIUPNP7Y7FPXDTQVINPTANCNFSM4ILJQPCA>.
|
Thank you for the suggestion. STR:
I understand the description regarding the vision framework is correct. So far, "browse mode cursor" is used only in the Content Recognition chapter of the User Guide and almost undocumented. |
The browse mode caret is the virtual caret used in all browse mode
situations, so also in browsers. It isn't the same as the review cursor
and therefore indeed, the review cursor position isn't shown. Most
important reason of this is that we don't always have the physical
position of the review cursor, so we can't reliably show it.
|
Link to issue number:
Follow up of #9064
Closes #971
Summary of the issue:
#9064 introduced the vision framework without a graphical user interface.
Description of how this pull request fixes the issue:
Added a new vision panel to the settings dialog. Vision enhancement providers can provide their own gui panel class to create a customized gui. Otherwise, they can rely on the supportedSettings property to be implemented on the provider.
Testing performed:
Tested that providers load and unload and that settings can be changed using the gui.
Known issues with pull request:
Change log entry:
There's also a wording issue in the changes for developers setting:
Àdded
to the start of that sentence. You could also consider updating this entry to point at the new vision category in the gui.