Vision framework: add a screen curtain #10090
Conversation
… remove all stuff we don't need
|
I am myself against nvda+ctrl+/
As it is not an universal keystroke.
Beware that the russian keyboard places slash on the very uncomfortable position.
It’s the same is for croatian.
Shift+7 is slash on croatian keyboard
Shift+backshlash is an slash
|
|
Looks like these keys can still be pressed, then.
I see your point, but honestly, I don't want this key stroke to be too
easy. People using it should really know what they're doing, i.e. they
should not trigger it by accident.
|
|
Well, but the 90% of the people i know in the russian polish and croatian communities would prefer something easier for toggling this.
|
|
Then they can remap the shortcut to something better for them, can't they? |
|
Yes, but you don’t see my point.
This shortcut will work only for qwerty us or pl keyboards.
It will not work on de or hr keyboards
Remapping this by default is not good user experience.
If something, let’s unmap it
|
|
Translators can already remap particular shortcuts for they language. If shortcut is really uncomfortable for a specific language community it should be remapped as part of the translation IMO. |
|
I'm open for suggestions.
|
|
Hi, I recommend leaving it (and NVDA highlighter toggle command) unassigned for this reason. Thanks.
|
|
How often does one really need to turn the screen curtain on and off? It's
usually the kind of setting that's on for days at a time.
I myself would like to have it as a three finger triple tap on the touch
screen, such as I am used to with Voiceover, so as not to waste one of my
precious key combinations. But that is not the majority's problem.
|
|
hello all.
i don't think you should do it because of on some layouts some
keystrokes cannot be pressed.
all keystrokes are up to users to set and everything is done in nvda
to easily remap it.
Besides russian, polish croatian and so on, there are lots of other
users of different nationalities and i don't think it would be good to
raise this kind of psewdo problem.
you are not going to present all users of your nation, so if some
particular user don't like keystroke, they can remap it easily.
so i don't think you should even take this point in to an account.
…On 8/14/19, Luke Davis ***@***.***> wrote:
How often does one really need to turn the screen curtain on and off? It's
usually the kind of setting that's on for days at a time.
I myself would like to have it as a three finger triple tap on the touch
screen, such as I am used to with Voiceover, so as not to waste one of my
precious key combinations. But that is not the majority's problem.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#10090 (comment)
--
with best regards beqa
|
|
Yes, but giving a non-working gesture in the user guide for a specified language or languages is not good user experience whatsoever.
|
|
As @josephsl pointed out, it will be tetter to have this unassigned, i.e user defined.
|
|
Hi łukasz,
No, translators cannot remap al keystrokes.
They can remap only hotkeys in the .po files, which start with and &.
|
|
zstanecic wrote:
No, translators cannot remap al keystrokes.
Yes, it is possible. In NVDA, locale each language have a gesture.ini,
and it is possible to adapte the keystrokes for each language and keyboard.
It is not easy, since that file is not part of the translation system...
Best regards,
Rui Fontes
… They can remap only hotkeys in the .po files, which start with and &.
From: Łukasz Golonka ***@***.***>
Sent: Tuesday, August 13, 2019 8:21 PM
To: nvaccess/nvda ***@***.***>
Cc: zstanecic ***@***.***>; Comment
***@***.***>
Subject: Re: [nvaccess/nvda] Vision framework: add a screen curtain (#10090)
Translators can already remap particular shortcuts for they language. If
shortcut is really uncomfortable for a specific language community it
should be remapped as part of the translation IMO.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10090?email_source=notifications&email_token=ACVCDE6HIONC4M5RSZHG2OTQEL3QBA5CNFSM4ILNBJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GQ7DQ#issuecomment-520949646>
, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACVCDE5L2W2QCSTX5KVXFR3QEL3QBANCNFSM4ILNBJZQ>
.
<https://github.com/notifications/beacon/ACVCDE4NURACXP7A5W6KFMDQEL3QBA5CNFSM4ILNBJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GQ7DQ.gif>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10090?email_source=notifications&email_token=ADZAPRSGDTPDCYXT4CXS3ADQEPCXPA5CNFSM4ILNBJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IFKTQ#issuecomment-521164110>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADZAPRRLCVAUKRLNYMGPQKLQEPCXPANCNFSM4ILNBJZQ>.
|
|
And here we are...
We cannot modify it, as our changes are not directly integrated in the NVDA from the translation system.
So... we can make zillion midifications, if we don’t have these integrated
|
|
I think most people have made their points clear. I think there are tree options:
Apart from feedback on option 2, I think that the point about gestures being incompatible to keyboard layouts sis an issue that is much broader than this particular pull request. Therefore, I'd like to kindly ask you to move discussion about this to one of the mailing lists, preferably NVDA devel. |
Co-Authored-By: André-Abush Clause <[email protected]>
|
Not really wanting to start the debate about a default gesture again. Personally I think it should be un-mapped by default. More importantly, a mechanism is necessary to prevent this getting stuck on. For a user who relies on sight, there is no warning that checking screen curtain will make it black. If this user had speech disabled, they may find it quite hard to turn screen curtain off. Suggestion:
When enabling or disabling screen curtain, I think it should be announced as a high priority. Something brief like "screen curtain disabled". As already mentioned, I expect turning on and off screen curtain will be rare. Getting feedback for such a deliberate action seems important to me. |
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit dfe910866f |
|
@feerrenrut: as discussed by voice, this is now in the stage where the globalCommand is unassigned by default but where there is no warning when initializing. Warning gui will be added to #10082 |
|
just a small typo: |
Link to issue number:
Closes #7857
Summary of the issue:
It has been a long awaited feature to make your screen black when using NVDA. There has been an initial version of this functionality in the Screen Curtain add-on. Now the vision framework is live, we can bring it to core very easily.
Description of how this pull request fixes the issue:
Adds a screen curtain based on the Windows Magnification API, windows 8 and above. This function is not supported for Windows 7. Since Windows 7 is EOL in around half a year, I do not care much myself. It shouldn't be too difficult to create something based on the code for the highlighter, but that's beyond the scope of this pr. It can be distributed as an add-on of course.
Testing performed:
Known issues with pull request:
Change log entry: