-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how enabled providers are saved in the config spec #10500
Conversation
…cted when the provider is off and all tree check boxes are on
PR introduces Flake8 errors 😲 See test results for Failed build of commit 9ab111802a |
So, this pr adds the enabled boolean to the config spec, but this entry could go out of sync with the settings in the settings storage. In the storage, all entries could be True even when enabled is False. If my theory is right, in this case when opening the vision dialog, the highlighter will be enabled as soon as you focus the vision category and will be disabled again if you cancel. I wonder what would be best to get this in sync. I think the enabled boolean in the config should take precedence over all provider specific settings, so if enabled is False and follow focus/caret/browse mode are off, the gui should show as was everything disabled. |
I'm fine with this. But only if the |
I think I've done as requested. |
Thanks @LeonarddeR I had a play with this, setting the enabled config state using the python console and got the expected behavior. |
Great!
|
Link to issue number:
Follow up of #10082
Related to #10476
Summary of the issue:
Currently, active vision enhancement providers are saved in a list. Therefore, the state of active providers is saved on a list basis, not per provider. This means that, once a profile changes the list of active vision enhancement providers, the full list is saved in that profile, rather than just the provider for which the state was changed in that profile.
Description of how this pull request fixes the issue:
Save enabled/disabled state of the provider in the provider section itself, as an enabled boolean.
Testing performed:
Tested tat activation/deactivation still works as expected.
Tested the following steps:
Known issues with pull request:
This does not solve the concern from #10476. I feel we should discuss this further before coming up with a solution.
Change log entry:
None