Change how enabled providers are saved in the config spec

[LeonarddeR]

Link to issue number:

Follow up of #10082
Related to #10476

Summary of the issue:

Currently, active vision enhancement providers are saved in a list. Therefore, the state of active providers is saved on a list basis, not per provider. This means that, once a profile changes the list of active vision enhancement providers, the full list is saved in that profile, rather than just the provider for which the state was changed in that profile.

Description of how this pull request fixes the issue:

Save enabled/disabled state of the provider in the provider section itself, as an enabled boolean.

Testing performed:

1. Tested tat activation/deactivation still works as expected.

2. Tested the following steps:

   1. Enable highlighter and screen curtain
   2. Switch profile
   3. Disable screen curtain.
   4. Switch back to default profile
   5. Ensure screen curtain and highlighter are both enabled
   6. Disable highlighter
   7. Switch back to the custom profile
   8. Ensure that both providers are disabled in the profile. Disabled state of the highlighter is inherrited from the default config, rather than saved in the profile.

Known issues with pull request:

This does not solve the concern from #10476. I feel we should discuss this further before coming up with a solution.

Change log entry:

None

[AppVeyorBot]

PR introduces Flake8 errors 😲

See test results for Failed build of commit 9ab111802a

[LeonarddeR]

So, this pr adds the enabled boolean to the config spec, but this entry could go out of sync with the settings in the settings storage. In the storage, all entries could be True even when enabled is False. If my theory is right, in this case when opening the vision dialog, the highlighter will be enabled as soon as you focus the vision category and will be disabled again if you cancel.

I wonder what would be best to get this in sync. I think the enabled boolean in the config should take precedence over all provider specific settings, so if enabled is False and follow focus/caret/browse mode are off, the gui should show as was everything disabled.

[feerrenrut]

I think the enabled boolean in the config should take precedence over all provider specific settings

I'm fine with this. But only if the enabled boolean is false, then it should override the other settings on load. When it's true, overriding the other settings would defeat their purpose.

[LeonarddeR]

I think I've done as requested.

[feerrenrut]

Thanks @LeonarddeR I had a play with this, setting the enabled config state using the python console and got the expected behavior.

[LeonarddeR]

Great!