VisionProviderSubPanel_Settings.hasOptions now returns False based on supportedSettings instead of sizerDict #10504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up of #10082
Summary of the issue:
For a provider that only has runtime settings and uses the VisionProviderSubPanel_Wrapper, the VisionProviderSubPanel_Settings would be properly hidden if the provider is disabled. After enabling and disabling the provider, the empty panel is still shown and can receive keyboard access.
Description of how this pull request fixes the issue:
Whether a panel had options was based on the sizerDict. However, for performance reasons, the sizerDict isn't cleared when updating the driver settings, the sizers for unsupported settings are only hidden. the sizerDict still remains populated.
This pr bases the hasOptions property on the supportedSettings property of the AutoSettings instance. It also moves the property to AutoSettingsMixin, since it's abstract enough to live there.
Testing performed:
Tested enabling and disabling of a provider with only runtime settings. Ensured that after disabling, the whole panel disappeared. Enabling the provider again reintroduced the panel along with its settings.
Known issues with pull request:
None
Change log entry:
None