Remove backwards compat code from IAccessibleHandler #12232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, removes code marked as deprecated in #10934
Summary of the issue:
PR #10934 refactored
IAccessibleHandler
into a package. This necessitated keeping some unused imports but marking them as deprecated. Also various parts of NVDA relied on the fact thatIAccessibleHandler
star imported all variables from IAccessible and IAccessible2 COM interfaces.Description of how this pull request fixes the issue:
IAccessibleHandler
IAccessibleHandler
.Testing strategy:
Manual testing:
Ensured that NVDA still starts, and works in general. Spend about an hour browsing in Firefox without any apparent changes in behavior.
With git grep inspected all usages of
IAccessibleHandler
to make sure that nothing in NVDA's source relies on things star imported there any longer.Known issues with pull request:
None known
Change log entry:
Section: Changes for developers:
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]
becomes[x]
.You can also check the checkboxes after the PR is created.