Fix-up of #12232: No longer falsely report that objects are inside GeckoIA2 virtual buffer if they aren't.

[lukaszgo1]

Link to issue number:

Fixes #12234- Regression introduced in #12232

Summary of the issue:

When working on #12232 I had to reformat quite a bit of code to comply with the style enforced by Linter. In the process logic responsible for checking if the given object is inside GeckoIA2 virtual buffer got broken. I haven't noticed it when testing because of #12227

Description of how this pull request fixes the issue:

The logic has been corrected.

Testing strategy:

After navigating in Firefox opened Windows Explorer, navigated in the list of files ensured that errors no longer occur.

Known issues with pull request:

None known

Change log entry:

None needed - regression in Alpha.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual tests.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.

[XLTechie]

As I confirmed on the issue, this does fix the regression.

[seanbudd]

Thanks @lukaszgo1!

[CyrilleB79]

Hello

The commit associated to this message is not so much explicit:

commit e1a937f3ae14f556090bea6b394b59d1ec2f9334 (HEAD -> master, nvaccess/master)
Author: <C5><81>ukasz Golonka <[email protected]>
Date:   Mon Mar 29 02:02:07 2021 +0200

   Fix for #12234 (#12236)

When reading commit history, it gives no information unless (fortunately) the ref of this PR and the associated issue. It's a pity for situation where one may search the commit history for a regression, etc.

It would have been more interesting to have put something more explicit such as something based on the title of this PR, e.g.:

Fix-up of #12232: No longer falsely report that objects are inside GeckoIA2 virtual buffer if they aren't. (#12236)

Please pay attention to it for next time.
Thanks.

[seanbudd]

Apologies, my mistake