Fix-up of #12232: No longer falsely report that objects are inside GeckoIA2 virtual buffer if they aren't. #12236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12234- Regression introduced in #12232
Summary of the issue:
When working on #12232 I had to reformat quite a bit of code to comply with the style enforced by Linter. In the process logic responsible for checking if the given object is inside GeckoIA2 virtual buffer got broken. I haven't noticed it when testing because of #12227
Description of how this pull request fixes the issue:
The logic has been corrected.
Testing strategy:
After navigating in Firefox opened Windows Explorer, navigated in the list of files ensured that errors no longer occur.
Known issues with pull request:
None known
Change log entry:
None needed - regression in Alpha.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]
becomes[x]
.You can also check the checkboxes after the PR is created.