Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify and vim.ui harmonization #118

Merged
merged 6 commits into from
May 12, 2022
Merged

feat: notify and vim.ui harmonization #118

merged 6 commits into from
May 12, 2022

Conversation

fdschmidt93
Copy link
Member

@fdschmidt93 fdschmidt93 commented Mar 26, 2022

Continuation of #72

Closes #91 #87

Changelog:

  • Use vim.ui.input and vim.notify everywhere
  • Smoothly pretty much all hit-enter prompts by redraw on vim.ui.input with default vim.notify and casting all messages on a single line (probably not amazing if tons of single files/folders are created/deleted/etc. but can deal with it later)
  • Introduce quiet option to suppress all outputs
  • Refactoring a proper config module
  • Disallow removing parent folder (file_browser) and current folder (folder_browser) (yes, I've done something like that accidentally in my testing.. all my lua repos had to be restored via timeshift haha)

Since it is a very large PR, I apologize in before for any regression caused :) In my testing I couldn't find any, I've been on this branch some time and retested important actions repeatedly, but I'm sure a larger user base will find things.

@fdschmidt93 fdschmidt93 force-pushed the feat/notify branch 3 times, most recently from f74e04a to 53e7622 Compare April 20, 2022 19:32
@fdschmidt93
Copy link
Member Author

@ikerurda may I kindly ask you to test drive this PR please? :)

@fdschmidt93 fdschmidt93 merged commit 159f82e into master May 12, 2022
@fdschmidt93 fdschmidt93 deleted the feat/notify branch May 12, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "quiet" config option to suppress action confirmation print statements
1 participant