-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: standardize fb_action user IO #72
refactor: standardize fb_action user IO #72
Conversation
Using vim.notify for output messages (log level = WARN for areas indicating missteps by users), vim.ui.input for inputs. All messages prefixed by `[telescope]` to be clear about the origins of the message. Checks off an item from nvim-telescope#3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome refactor
return msg | ||
end | ||
|
||
-- Move this and above functions into telescope core? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
Sorry, a bit too lazy right now as I've had worked on tons on the file browser in the weeks before. I'll try to get to have a first brief crack at this either tomorrow or Sunday :) E: And of course thanks for your PR :) |
closes #91 I've spent some more time looking for solutions for #87 but I'm able to find something that works consistently. If anybody has any suggestions, that'll be great. |
1cd81e4
to
b219603
Compare
I've now looked a bit more at this as I'll eventually will take this over. Couple of notes:
I'll try to work incrementally and push the PR maybe in a week or two. Thanks again anyways :) |
Using
vim.notify
for output messages (log level = WARN for areas indicating missteps by users),vim.ui.input
for inputs.All messages prefixed by
[telescope]
to be clear about the origins of the message.Checks off an item from #3