-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bld): add languageCode option for Windows #1175
Conversation
WankkoRee
commented
Jul 26, 2024
•
edited by ayushmanchhabra
Loading
edited by ayushmanchhabra
- Set Windows properties correctly (previously version property was used to incorrectly set ProductVersion)
11ecb26
to
ed69996
Compare
ed69996
to
f353f4a
Compare
Could you elaborate on productVersionMS and productVersionLS and how this PR sets it correctly? |
about productVersion, set it correctly by test options: nwbuild({
mode: "build",
version: "0.50.3",
....,
app: {
productVersion: "1.2.3.4",
},
}) before: you can see it, the product version string was set correctly, but the product version code was not. after: |
Great, thanks! I actually wanted to know the difference between ProductVersionLS and ProductVersionLS which you mentioned in the PR description. Here is what I found out about the two: |
I don't know the difference between them either. I just see it at: |
I add back the version property. In addition, I also make docs and code logic consistent. |
🤖 I have created a release *beep* *boop* --- ## [4.8.0](v4.7.8...v4.8.0) (2024-07-27) ### Features * **bld:** add languageCode option for Windows ([#1175](#1175)) ([96ad585](96ad585)) ### Bug Fixes * **bld:** pass nw manifest correctly when managedManifest is true ([#1176](#1176)) ([949c4b7](949c4b7)) ### Chores * **ci:** check for valid licenses ([#1150](#1150)) ([ab99731](ab99731)) * **deps:** bump actions/setup-node from 4.0.2 to 4.0.3 in /.github/workflows in the gha group ([#1151](#1151)) ([7130930](7130930)) * **deps:** bump the npm group across 1 directory with 8 updates ([#1177](#1177)) ([9410455](9410455)) * **deps:** migrate from compressing to tar and archiver ([7c73903](7c73903)) * **docs:** improve install/quick start ([a87f44b](a87f44b)) * fsm -> fs.promises ([08d79bf](08d79bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks! |
* Setup fixtures for Linux, MacOS and Windows systems * Undeprecate options.version #1175 * Implement logging * Listen for Ctrl+C and delete partially downloaded file * Mention a gotcha regarding icon