Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: miscellaneous quality of life improvements #1296

Merged
merged 47 commits into from
Nov 9, 2024
Merged

fix: miscellaneous quality of life improvements #1296

merged 47 commits into from
Nov 9, 2024

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Nov 8, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 32.73% 569 / 1738
🔵 Statements 32.73% 569 / 1738
🔵 Functions 38.7% 12 / 31
🔵 Branches 69.56% 32 / 46
File CoverageNo changed files found.
Generated in workflow #988 for commit 582591d by the Vitest Coverage Report Action

@ayushmanchhabra ayushmanchhabra changed the title chore(test): setup fixtures for Linux, MacOS and Windows systems tbd Nov 8, 2024
@ayushmanchhabra ayushmanchhabra changed the title tbd fix: miscellaneous quality of life improvements Nov 8, 2024
@ayushmanchhabra
chore(bld): update docs link
c1ccd81
@ayushmanchhabra
chore(docs): update roadmap
523b445
@ayushmanchhabra
chore(util): add in house log function
c444b69
@ayushmanchhabra
chore(util): check for invalid input
56905ca
@ayushmanchhabra
chore(util): check for invalid input
67bc126
@ayushmanchhabra
chore(test): try out log function
e705ea0
@ayushmanchhabra
fix(get): listen for Ctrl+C and delete partially downloaded file
0ef2df3
@ayushmanchhabra
fix(docs): correct default value of options.app.legalCopyright for Wi…
79696d3 
…ndows
@ayushmanchhabra
chore(docs): clarify options.app.fileVersion default values
0724887
@ayushmanchhabra
chore(docs): clarify terminology regarding package.json
92d8dab
@ayushmanchhabra
chore(test): configure initial Windows build
2c774d8
@ayushmanchhabra
chore: create CLI command to build and execute Windows NW.js demo app
8bfbcea
@ayushmanchhabra
chore: create CLI command to build and execute Windows NW.js demo app
9aaa5d7
@ayushmanchhabra
fix(test): point to valid icon path
3652910
@ayushmanchhabra
chore(get): correct spelling in code comments
60470f4
@ayushmanchhabra
chore(bld): improve readability
c0e1fed
@ayushmanchhabra
chore(test): update title from NW.js Demo to Demo since it shows in T…
ba081f5 
…askbarc
@ayushmanchhabra
chore: add some logs so user knows status of process
8124ad5
@ayushmanchhabra
chore(test): update options.app.legalCopyright
1bee729
@ayushmanchhabra
chore(test): add options.app.NSLocalNetworkUsageDescription to MacOS …
1963641 
…demo
@ayushmanchhabra
fix(util): parse options.app.exec path correctly
506e4f2
@ayushmanchhabra
chore(test): create linux fixture
243256f
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review November 9, 2024 03:11
@ayushmanchhabra ayushmanchhabra merged commit a82c140 into main Nov 9, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the test/fixtures branch November 9, 2024 03:36
@github-actions github-actions bot mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayushmanchhabra