Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch after state updates should be reflected in tracking data #59

Closed
tizmagik opened this issue Oct 16, 2017 · 1 comment
Closed

Dispatch after state updates should be reflected in tracking data #59

tizmagik opened this issue Oct 16, 2017 · 1 comment
Labels
bug Hacktoberfest help wanted

Comments

@tizmagik
Copy link
Collaborator

Failing test case here #58 thanks to @tanhauhau

This is a bit of an edge case, but the usage looks natural so as a user of this library I'd expect it to work as is asserted in the test case.
@tizmagik tizmagik changed the title Dispatch after state updates should reflect updated tracking data Dispatch after state updates should be reflected in tracking data Oct 16, 2017
tanhauhau added a commit to tanhauhau/react-tracking that referenced this issue Oct 17, 2017
@tanhauhau
Fix Issue nytimes#59 dispatch after state updates should be reflected…
9c77660 
… in tracking data
@tanhauhau tanhauhau mentioned this issue Oct 17, 2017
Merged
tizmagik pushed a commit that referenced this issue Oct 17, 2017
@tanhauhau @tizmagik
Fix issue 59 (#60)
17da891 
* e2e test - will dispatch different data if props changed

* Fix Issue #59 dispatch after state updates should be reflected in tracking data

* Fix eslint

* Fix eslint

* Fix eslint
@tizmagik
Copy link
Collaborator Author

Fixed in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tizmagik