Fix issue 59 #60
Merged
Fix issue 59 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizmagik
reviewed
Oct 17, 2017
src/__tests__/e2e.test.js
Outdated
| @track({ event: 'buttonClick' }) | ||
| handleClick = jest.fn(); | ||
| render() { | ||
| return <span onClick={this.handleClick}>Click Me</span>; |
There was a problem hiding this comment.
Linting is failing on this line, you can just // eslint-disable-line jsx-a11y/no-static-element-interactions
tizmagik
reviewed
Oct 17, 2017
src/__tests__/e2e.test.js
Outdated
| @@ -453,6 +453,7 @@ describe('e2e', () => { | |||
|
|
|||
| @track({ page: 'Page' }) | |||
| class Page extends React.Component { | |||
| // eslint-disable-line jsx-a11y/no-static-element-interactions | |||
There was a problem hiding this comment.
Ah it would have to go on the line that's giving the error L460. You can probably just disable this rule for the entire file, and put this at the top:
/* eslint-disable jsx-a11y/no-static-element-interactions */There was a problem hiding this comment.
ah. fixed. thanks @tizmagik
tizmagik
approved these changes
Oct 17, 2017
This was referenced Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59
IMHO, you can either compute the tracking data lazily only when tracking is being called or eagerly whenever props changed.
Currently, the tracking data is being computed eagerly in the constructor, so for the minimal code change, i added the same computing call in the
componentWillReceiveProps