Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve running command from subfolder #139

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Improve running command from subfolder #139

merged 2 commits into from
Nov 1, 2019

Conversation

rockisch
Copy link
Contributor

Related Issue: #129

So, while doing some investigation, I discovered that whenever the git cmd is executed in a subfolder, it does a recursive search for the git repo on the current path.

Although the impact on this program is very low, since we only do ~10 git calls per run, I was already going to extract the working dir to fix the LICENSE issue, so why not improve the other calls?

Also, we can't call workdir() on bare git folders, but the program was already not working on them, since they don't have any content.

I can also reorder the functions that receive the Repository to keep the code more uniform, but some people don't like big git changes since it messes their git blame ¯\(ツ)

@spenserblack
Copy link
Collaborator

spenserblack commented Oct 31, 2019

I can also reorder the functions that receive the Repository to keep the code more uniform, but some people don't like big git changes since it messes their git blame ¯(ツ)/¯

We've already had some big changes recently (#98), so I don't think it's an issue.

@rockisch
Copy link
Contributor Author

rockisch commented Nov 1, 2019

I reordered the functions to keep the code more consistent, besides updating the branch to match master.

@spenserblack spenserblack merged commit 9382549 into o2sh:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants