Improve running command from subfolder #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #129
So, while doing some investigation, I discovered that whenever the
git
cmd is executed in a subfolder, it does a recursive search for the git repo on the current path.Although the impact on this program is very low, since we only do ~10 git calls per run, I was already going to extract the working dir to fix the LICENSE issue, so why not improve the other calls?
Also, we can't call
workdir()
on bare git folders, but the program was already not working on them, since they don't have any content.I can also reorder the functions that receive the
Repository
to keep the code more uniform, but some people don't like big git changes since it messes their git blame ¯\(ツ)/¯