-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor modules into files #98
Conversation
Why did you remove the The Info module is indeed quite large. Anyway, this is already well organized 🥇 @andymac-2 I'll let you merge your PR after the conflicts are resolved. Thanks again! |
In response to the removal of the
Which used to look something like...
...in a previous version of the code that had a different |
Don't merge this just yet, I've still got to update the tests. EDIT: Done |
Okay, that should be it. The tests have been updated. |
Oops, I went too fast.
|
Oh whoops, that was definitely a victim of a large merge. Those commits occurred while I was moving things to different modules. As far as I can tell there are no other changes that were rolled back. |
No problem, merges are the worst. Plz push the correction when possible. |
Fixes #97
The program is split into several modules, the largest (the info module) is already logically quite simple, and it would not make much sense to split it any further in my opinion.
I may have broken something, but as far as I can tell through my testing, this refactor went quite smoothly.
It might be good to further refactor the
Info::new
method to have less arguments.I also ran
rustfmt
on the resulting code since I'm changing pretty much every line anyway.