Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates after repository transfer #11

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 16, 2020

No description provided.

@kostko kostko marked this pull request as ready for review September 16, 2020 12:01
@kostko kostko requested a review from tjanez September 16, 2020 12:01
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be an action for publishing to npm? (or will that be done manually?)

steps:
- name: Checkout code
uses: actions/checkout@v2
with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to remove this work-around. It has been fixed for a while: actions/checkout#237 (comment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is still not closed actions/checkout#299?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, but it has been indicated that it is a duplicate of actions/checkout#237 and I think it should be closed.

README.md Outdated Show resolved Hide resolved
@tjanez
Copy link
Member

tjanez commented Sep 16, 2020

Should there also be an action for publishing to npm? (or will that be done manually?)

@ptrus, did you just volunteer for that 🙂?

Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it looks good!

@kostko
Copy link
Member Author

kostko commented Sep 16, 2020

Should there also be an action for publishing to npm? (or will that be done manually?)

Also for the release process, but let's do that separately once we introduce a proper release process (will open an issue).

@kostko kostko merged commit cabe2d2 into master Sep 16, 2020
@kostko kostko deleted the kostko/fix/after-transfer branch September 16, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants