-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on pull request, checkout@v2 built some ref other than the one that was claimed #237
Comments
Thanks! I'll loop in some folks. Indeed something looks wrong. From the
Yet appears to contradict the
It looks like [edit]: The commit message should read: |
@andymckay have you heard of any similar occurrences? The workflow payload contained the wrong merge commit. |
👋🏾 Will be taking a look into this today and tomorrow. |
Thanks @iheanyi for digging into this! We dug into this a bit and are unable to reproduce. This may be due to replication lag (received previous merge commit). Going forward we'll add more telemetry to the checkout step. So if this happens again we will be able to detect from telemetry. |
Also switch to older, hopefully less buggy checkout action. actions/checkout#237
Hi, I just ran in to this same issue here: https://github.com/PhotonVision/photonvision/pull/18/checks?check_run_id=844516246 |
v2 looks to have a bug where sometimes picking up the wrong commit. actions/checkout#237
v2 looks to have a bug where sometimes picking up the wrong commit. actions/checkout#237
Same happens when using with |
My configuration is like:
Despite I'm checking out the right HEAD, I see some extra merge commits: |
Here are more details based on the build 866142019. I'm pushing my changes using
So my HEAD changed from
Where |
It happens to me, too. It runs the action on the project's wrong commit Go to An you will see that the 5d8abdc commit number isn't in the log:
And it happens again in https://github.com/PyAr/CDPedia/runs/871872757
Thank you! |
codecov reports are not being posted to PRs. Downgrade suggested: actions/checkout#237 https://community.codecov.io/t/codecov-status-stuck-at-waiting-for-status-to-be-reported-on-github/341/40
This reverts commit 8aaa7c8. The bug it was working around (if it ever did) has been fixed.
Revert "Downgrade to checkout@v1 to work around actions/checkout#237"
@andymckay it would be good to update this issue with the exact version number of checkout@v2 where the issue was fixed. |
@andymckay This is re-occuring. My whole CI is completely broken and corrupted. Help Edit: I was wrong it was another issue |
@Mubelotix I would recommend you contact customer support here: https://support.github.com/ Or you can open a new issue on this repository with as much information as you've got so the team can take a look. |
* build: fixed `umd/es5` declaration file * docs: updated download urls * chore(deps-dev): bump @typescript-eslint/parser from 5.10.0 to 5.10.1 (#125) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.10.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump webpack-cli from 4.9.1 to 4.9.2 (#127) Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 4.9.1 to 4.9.2. - [Release notes](https://github.com/webpack/webpack-cli/releases) - [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-cli/compare/[email protected]@4.9.2) --- updated-dependencies: - dependency-name: webpack-cli dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @typescript-eslint/eslint-plugin (#126) * docs: gitter badge * chore(deps-dev): bump es-check from 6.1.1 to 6.2.1 (#130) * chore(deps-dev): bump eslint from 8.7.0 to 8.8.0 (#131) * chore(deps-dev): bump @typescript-eslint/eslint-plugin (#134) * chore(deps-dev): bump webpack from 5.67.0 to 5.68.0 (#133) * chore(deps-dev): bump @typescript-eslint/parser from 5.10.1 to 5.10.2 (#132) * build: es2017 as default output * docs: updated benchmark * chore: added .npmignore * docs: updated benchmark * docs: more examples * style: formatted code * docs: fixed benchmark * ci: fixed actions/checkout#237 * chore: codecov bug was not fixed :( * chore(deps-dev): bump jest from 27.4.7 to 27.5.0 (#136) * chore(deps-dev): bump @typescript-eslint/eslint-plugin (#138) * deps: updated dependencies * tag: v0.8.6 * no: way that I did that * tag: v0.8.7 * fix: now npmignore is happy * tag: v0.8.8 * docs: updated download urls Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
More information in this - actions/checkout#237
More information in this - actions/checkout#237
More information in this - actions/checkout#237
Recently, I had a PR adafruit/circuitpython#2831 which checked out green, so a fellow developer merged it. It broke the build.
In subsequent investigation, I noticed that while the linked Actions run https://github.com/adafruit/circuitpython/runs/633447824?check_suite_focus=true shows that it was building the same ref as the one that was merged, down in the logs you find something different.
Under the step "Run actions/checkout@v2", "Checking out the ref",
6dfe9ab represents another revision of the code that was apparently replaced by force-push with the later value 75be728:
The text was updated successfully, but these errors were encountered: