Replace type definition for dubious synonyms #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks. Yes, the other types would be useful too
…On Sat, Sep 23, 2023 at 2:14 AM Charles Tapley Hoyt < ***@***.***> wrote:
This PR demonstrates replacing the *ad hoc* synonym type definition
inside UBERON for dubious/contested synonyms with standard ones from OMO.
The diff is relatively small, but if there are no issues with this, I can
easily extend it to the definitions for ABBREVIATION, DEPRECATED,
MISSPELLING, and PLURAL.
------------------------------
You can view, comment on, or merge this pull request online at:
#3077
Commit Summary
- 40c0a9f
<40c0a9f>
Replace type definition for dubious synonyms
File Changes
(1 file <https://github.com/obophenotype/uberon/pull/3077/files>)
- *M* src/ontology/uberon-edit.obo
<https://github.com/obophenotype/uberon/pull/3077/files#diff-7dde9e81f71ce11962436529956798fa723e49d1bc8d188cc399d8009c2f72b4>
(30)
Patch Links:
- https://github.com/obophenotype/uberon/pull/3077.patch
- https://github.com/obophenotype/uberon/pull/3077.diff
—
Reply to this email directly, view it on GitHub
<#3077>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGZRCG3CJFWXWLRKJ3XIJ3X32SA3ANCNFSM6AAAAAA5ECDKBM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@uberon I can do them all in this PR or we can do it in an incremental way, what's your preference? |
|
Sorry, this needs to be moved to the next release because I didn't import OMO:0003002 previously, and I don't have much more time to run the release today. |
cmungall
previously approved these changes
Nov 22, 2023
|
Still need to import OMO:0003002 here |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
@anitacaron I added the appropriate OMO import |
|
I'm updating |
anitacaron
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates replacing the ad hoc synonym type definition inside UBERON for dubious/contested synonyms with standard ones from OMO.
The diff is relatively small, but if there are no issues with this, I can easily extend it to the definitions for
ABBREVIATION,DEPRECATED,MISSPELLING, andPLURAL.Depends on