Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destruct shouldn't produce same patterns in an existing pattern-match #1560

Closed
ulugbekna opened this issue Jan 15, 2023 · 0 comments · Fixed by #1737, ocaml/opam-repository#25902 or ocaml/opam-repository#26002
Closed

Destruct shouldn't produce same patterns in an existing pattern-match #1560

ulugbekna opened this issue Jan 15, 2023 · 0 comments · Fixed by #1737, ocaml/opam-repository#25902 or ocaml/opam-repository#26002

Comments

@ulugbekna
Copy link
Contributor

Destructing a wildcard pattern in a match, one can get cases that are already present in the match. It would be great to not produce such cases at least in simple cases, e.g.,

Screen.Recording.2023-01-15.at.16.36.43.mov
@xvw xvw mentioned this issue Feb 23, 2024
Merged
voodoos added a commit that referenced this issue Feb 26, 2024
@voodoos
destruct: Removal of residual patterns (#1737)
3488e07 
fixes #1560

from xvw/1560-destruct-should-not-produce-remanent-cases
voodoos added a commit to voodoos/merlin that referenced this issue May 13, 2024
@voodoos
[B] destruct: Removal of residual patterns (ocaml#1737)
6a822e5 
fixes ocaml#1560

from xvw/1560-destruct-should-not-produce-remanent-cases
voodoos added a commit to voodoos/opam-repository that referenced this issue May 17, 2024
@voodoos
[new release] merlin (3 packages) (5.0-502)
1fded17 
CHANGES:

Fri May 17 19:59:42 CET 2024

  + merlin binary
    - Support for OCaml 5.2 (ocaml/merlin#1757)
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
    - Addition of a `merlin-lib.commands` library which disassociates the
      execution of commands from the `new_protocol`, from the binary, allowing
      it to be invoked from other projects (ocaml/merlin#1758)
    - New occurrences backend: Don't index occurrences when `merlin.hide`
      attribute is present. (ocaml/merlin#1768)
    - Use the new `uid_to_decl` table in 5.2's cmt files to get documentation.
      (ocaml/merlin#1773)
@voodoos voodoos mentioned this issue May 17, 2024
Merged
voodoos added a commit to voodoos/opam-repository that referenced this issue May 31, 2024
@voodoos
[new release] merlin (3 packages) (4.15-501)
2cf5ede 
CHANGES:

May May 31 14:02:42 CET 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
voodoos added a commit to voodoos/opam-repository that referenced this issue May 31, 2024
@voodoos
[new release] merlin (3 packages) (4.15-414)
49ef452 
CHANGES:

Fri May 31 14:02:42 CEST 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
voodoos added a commit to voodoos/opam-repository that referenced this issue May 31, 2024
@voodoos
[new release] merlin (3 packages) (4.15-501)
f6fdba8 
CHANGES:

Fri May 31 14:02:42 CEST 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
voodoos added a commit to voodoos/opam-repository that referenced this issue May 31, 2024
@voodoos
[new release] merlin and merlin-lib v4.15-414/501
776ae45 
CHANGES:

Fri May 31 14:02:42 CEST 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
@voodoos voodoos mentioned this issue May 31, 2024
Merged
avsm pushed a commit to avsm/opam-repository that referenced this issue Sep 5, 2024
@voodoos @avsm
[new release] merlin and merlin-lib v4.15-414/501
c9ab3f5 
CHANGES:

Fri May 31 14:02:42 CEST 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ulugbekna