Extract commands from new protocol inside a dedicated library #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvw
force-pushed
the
tunneling-merlin-lsp-p1-split-protocol
branch
from
4500bed
to
ed5b519
Compare
xvw
changed the title
xvw
changed the title
voodoos
reviewed
May 6, 2024
There was a problem hiding this comment.
Thanks @xvw !
It's nice to realize that Query_json actually doesn't depends on Yojson :-)
Did you also check that other important parsing function such as the one parsing the flags to build the configuration are already exposed by merlin lib ?
voodoos
approved these changes
May 13, 2024
Yes. I am integrating test into my |
|
@xvw I merged the upgrade of master to 5.2, could you rebase that PR ? Thank you ! |
xvw
force-pushed
the
tunneling-merlin-lsp-p1-split-protocol
branch
from
24e9794
to
089ee97
Compare
|
Done! |
Moves the commands in the new protocol to a dedicated library (used by the binary) which can be used by `ocaml-lsp`.
xvw
force-pushed
the
tunneling-merlin-lsp-p1-split-protocol
branch
from
089ee97
to
46e4faf
Compare
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
May 17, 2024
CHANGES:
Fri May 17 19:59:42 CET 2024
+ merlin binary
- Support for OCaml 5.2 (ocaml/merlin#1757)
- destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
- Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
fixes ocaml/merlin#1661)
- Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
- Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
- Improve cursor position detection in longidents (ocaml/merlin#1756)
- Addition of a `merlin-lib.commands` library which disassociates the
execution of commands from the `new_protocol`, from the binary, allowing
it to be invoked from other projects (ocaml/merlin#1758)
- New occurrences backend: Don't index occurrences when `merlin.hide`
attribute is present. (ocaml/merlin#1768)
- Use the new `uid_to_decl` table in 5.2's cmt files to get documentation.
(ocaml/merlin#1773)
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Jun 10, 2024
…lit-protocol Extract commands from new protocol inside a dedicated library
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Jun 10, 2024
…lit-protocol Extract commands from new protocol inside a dedicated library
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 10, 2024
CHANGES:
Mon Jun 10 17:35:42 CEST 2024
+ merlin binary
- Addition of a `merlin-lib.commands` library which disassociates the
execution of commands from the `new_protocol`, from the binary, allowing
it to be invoked from other projects (ocaml/merlin#1758)
- `merlin-lib.commands`: Add a `find_command_opt` alternative to
`find_command` that does not raise (ocaml/merlin#1778)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 10, 2024
CHANGES:
Mon Jun 10 17:35:42 CEST 2024
+ merlin binary
- Addition of a `merlin-lib.commands` library which disassociates the
execution of commands from the `new_protocol`, from the binary, allowing
it to be invoked from other projects (ocaml/merlin#1758)
- `merlin-lib.commands`: Add a `find_command_opt` alternative to
`find_command` that does not raise (ocaml/merlin#1778)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 10, 2024
CHANGES:
Mon Jun 10 17:35:42 CEST 2024
+ merlin binary
- Addition of a `merlin-lib.commands` library which disassociates the
execution of commands from the `new_protocol`, from the binary, allowing
it to be invoked from other projects (ocaml/merlin#1758)
- `merlin-lib.commands`: Add a `find_command_opt` alternative to
`find_command` that does not raise (ocaml/merlin#1778)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES:
Mon Jun 10 17:35:42 CEST 2024
+ merlin binary
- Addition of a `merlin-lib.commands` library which disassociates the
execution of commands from the `new_protocol`, from the binary, allowing
it to be invoked from other projects (ocaml/merlin#1758)
- `merlin-lib.commands`: Add a `find_command_opt` alternative to
`find_command` that does not raise (ocaml/merlin#1778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on
voodoos/502(#1757)In order to easily enable tunneling, via a custom query from
ocaml-lsp, a large part of the argument processing logic (argv) can be used. This branch separates the command invocation logic (and the dispatching of CLI arguments to usefulmerlin-libfunctionality) into a dedicated library, which can be used from withinocaml-lsp.