Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

501-preview doesn't interpret the -cmi-file flag on the command line. #1703

Closed
ncik-roberts opened this issue Nov 14, 2023 · 1 comment · Fixed by ocaml/opam-repository#24882
Closed

501-preview doesn't interpret the -cmi-file flag on the command line. #1703

ncik-roberts opened this issue Nov 14, 2023 · 1 comment · Fixed by ocaml/opam-repository#24882

Comments

@ncik-roberts
Copy link
Contributor

-cmi-file was added as a flag upstream for type-checking a file against a specified interface.

This was merged into merlin's 501 and 501-preview branches, but seemingly only halfway. The Clflags.cmi_file ref was merged, and is referenced in src/ocaml/typing/typemod.ml, without the corresponding argument-parsing code in src/kernel/mconfig.ml.

I'm not sure if this was intentional or not, so I thought I'd open an issue.
@voodoos
Copy link
Collaborator

voodoos commented Nov 15, 2023

Thanks for the report Nick, that indeed sounds like an oversight, I will have a look.

voodoos added a commit to voodoos/merlin that referenced this issue Nov 21, 2023
@voodoos
Add test illustrating ocaml#1703
f4ecb5c 
Merlin has no use for the `-cmi-file` flag but should not reject it.
voodoos added a commit to voodoos/merlin that referenced this issue Nov 21, 2023
@voodoos
Add -cmi-file to the ignored flags. Fixes ocaml#1703
fcc769f
@voodoos voodoos mentioned this issue Nov 21, 2023
Merged
voodoos added a commit to voodoos/opam-repository that referenced this issue Dec 1, 2023
@voodoos
[new release] merlin (3 packages) (4.13-501)
7f3b693 
CHANGES:

Fri Dec  1 15:00:42 CET 2023

  + merlin binary
    - Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
    - Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
      ocaml/merlin#1705)
    - Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
      ocaml/merlin#1703)
    - Fix Merlin locate not fallbacking on the correct file in case of ambiguity
      (@goldfirere, ocaml/merlin#1699)
    - Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
      ocaml/merlin#1704)
  + editor modes
    - vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
    - emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
voodoos added a commit to voodoos/opam-repository that referenced this issue Dec 1, 2023
@voodoos
[new release] merlin (3 packages) (4.13.1-501)
908be25 
CHANGES:

Fri Dec  1 15:00:42 CET 2023

  + merlin binary
    - Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
    - Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
      ocaml/merlin#1705)
    - Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
      ocaml/merlin#1703)
    - Fix Merlin locate not fallbacking on the correct file in case of ambiguity
      (@goldfirere, ocaml/merlin#1699)
    - Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
      ocaml/merlin#1704)
    - Add support for OCaml 5.1.1 (ocaml/merlin#1714)
  + editor modes
    - vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
    - emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
@voodoos voodoos mentioned this issue Dec 1, 2023
Merged
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add test illustrating ocaml#1703
2bdeff1 
Merlin has no use for the `-cmi-file` flag but should not reject it.
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add -cmi-file to the ignored flags. Fixes ocaml#1703
e0dda72
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add test illustrating ocaml#1703
4012a91 
Merlin has no use for the `-cmi-file` flag but should not reject it.
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add -cmi-file to the ignored flags. Fixes ocaml#1703
742f484
nberth pushed a commit to nberth/opam-repository that referenced this issue Jun 18, 2024
@voodoos @nberth
[new release] merlin-lib and merlin (4.13.1-501)
adad0b5 
CHANGES:

Fri Dec  1 15:00:42 CET 2023

  + merlin binary
    - Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
    - Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
      ocaml/merlin#1705)
    - Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
      ocaml/merlin#1703)
    - Fix Merlin locate not fallbacking on the correct file in case of ambiguity
      (@goldfirere, ocaml/merlin#1699)
    - Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
      ocaml/merlin#1704)
    - Add support for OCaml 5.1.1 (ocaml/merlin#1714)
  + editor modes
    - vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
    - emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)

[new release] merlin-lib and merlin (4.13-501)

CHANGES:

Fri Dec  1 15:00:42 CET 2023

  + merlin binary
    - Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
    - Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
      ocaml/merlin#1705)
    - Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
      ocaml/merlin#1703)
    - Fix Merlin locate not fallbacking on the correct file in case of ambiguity
      (@goldfirere, ocaml/merlin#1699)
    - Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
      ocaml/merlin#1704)
  + editor modes
    - vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
    - emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)

[new release] merlin-lib and merlin (4.13-414)

CHANGES:

Fri Dec  1 15:00:42 CET 2023

  + merlin binary
    - Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
    - Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
      ocaml/merlin#1705)
    - Fix Merlin locate not fallbacking on the correct file in case of ambiguity
      (@goldfirere, ocaml/merlin#1699)
    - Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
      ocaml/merlin#1704)
  + editor modes
    - vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
    - emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new release] merlin-lib and merlin (4.13.1-501) with support for 5.1.1 voodoos/opam-repository
2 participants
@voodoos @ncik-roberts