Fixed Merlin recovery causing incorrect error messages #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Refis <[email protected]>
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Dec 1, 2023
from voodoos/issue1704-bad-error-messages
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 1, 2023
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 1, 2023
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 1, 2023
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
- Add support for OCaml 5.1.1 (ocaml/merlin#1714)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 1, 2023
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
- Add support for OCaml 5.1.1 (ocaml/merlin#1714)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
[new release] merlin-lib and merlin (4.13-501)
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
[new release] merlin-lib and merlin (4.13-414)
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
PizieDust
pushed a commit
to PizieDust/merlin
that referenced
this pull request
Dec 4, 2023
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 18, 2023
CHANGES:
Mon Dec 18 16:42:00 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 18, 2023
CHANGES:
Mon Dec 18 16:42:00 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
- Add support for OCaml 5.1.1 (ocaml/merlin#1714)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
[new release] merlin-lib and merlin (4.13-501)
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Ignore the new 5.1 `cmi-file` flag instead of rejecting it (ocaml/merlin#1710, fixes
ocaml/merlin#1703)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
[new release] merlin-lib and merlin (4.13-414)
CHANGES:
Fri Dec 1 15:00:42 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES:
Mon Dec 18 16:42:00 CET 2023
+ merlin binary
- Fix a follow-up issue to the preference of non-ghost nodes introduced in ocaml/merlin#1660 (ocaml/merlin#1690, fixes ocaml/merlin#1689)
- Add `-cache-lifespan` flag, that sets cache invalidation period. (ocaml/merlin#1698,
ocaml/merlin#1705)
- Fix Merlin locate not fallbacking on the correct file in case of ambiguity
(@goldfirere, ocaml/merlin#1699)
- Fix Merlin reporting errors provoked by the recovery itself (ocaml/merlin#1709, fixes
ocaml/merlin#1704)
+ editor modes
- vim: load merlin when Vim is compiled with +python3/dyn (e.g. MacVim)
- emacs: highlight only first error line by default (ocaml/merlin#1693, fixes ocaml/merlin#1663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1704