Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release of datakit #10802

Merged
merged 1 commit into from
Nov 23, 2017
Merged

New release of datakit #10802

merged 1 commit into from
Nov 23, 2017

Conversation

samoht
Copy link
Member

@samoht samoht commented Nov 21, 2017

CHANGES:

@samoht
Copy link
Member Author

samoht commented Nov 21, 2017

/cc @djs55 and @talex5

@camelus
Copy link
Contributor

camelus commented Nov 21, 2017

✅ All lint checks passed cff633d
  • These packages passed lint tests: datakit-bridge-github.0.12.0, datakit-bridge-local-git.0.12.0, datakit-ci.0.12.0, datakit-client-9p.0.12.0, datakit-client-git.0.12.0, datakit-client.0.12.0, datakit-github.0.12.0, datakit-server-9p.0.12.0, datakit-server.0.12.0, datakit.0.12.0

✅ Installability check (7790 → 7800)
  • new installable packages (10): datakit.0.12.0 datakit-bridge-github.0.12.0
    datakit-bridge-local-git.0.12.0 datakit-ci.0.12.0 datakit-client.0.12.0
    datakit-client-9p.0.12.0 datakit-client-git.0.12.0
    datakit-github.0.12.0 datakit-server.0.12.0 datakit-server-9p.0.12.0

@samoht
Copy link
Member Author

samoht commented Nov 22, 2017

cohttp.0.99 failure on 4.03:

[31m#===�[m �[01mERROR�[m �[01mwhile installing cohttp.0.99.0�[m �[31m=====================================#�[m
�[33m#�[m �[33mopam-version�[m 1.2.2
�[33m#�[m �[33mos�[m           linux
�[33m#�[m �[33mcommand�[m      jbuilder build -p cohttp -j 4
�[33m#�[m �[33mpath�[m         /home/travis/.opam/4.03.0/build/cohttp.0.99.0
�[33m#�[m �[33mcompiler�[m     4.03.0
�[33m#�[m �[33mexit-code�[m    1
�[33m#�[m �[33menv-file�[m     /home/travis/.opam/4.03.0/build/cohttp.0.99.0/cohttp-30047-ab0078.env
�[33m#�[m �[33mstdout-file�[m  /home/travis/.opam/4.03.0/build/cohttp.0.99.0/cohttp-30047-ab0078.out
�[33m#�[m �[33mstderr-file�[m  /home/travis/.opam/4.03.0/build/cohttp.0.99.0/cohttp-30047-ab0078.err
�[33m### stderr ###
�[m�[33m# �[m[...]
�[33m# �[mFile "cohttp/src/link.ml", line 123, characters 10-11:
�[33m# �[mError: Multiple definition of the module name Fields.
�[33m# �[m       Names must be unique in a given structure or signature.
�[33m# �[m    ocamlopt cohttp/src/cohttp__Link.{cmx,o} (exit 2)
�[33m# �[m(cd _build/default && /home/travis/.opam/4.03.0/bin/ocamlopt.opt -w -40 -g -I /home/travis/.opam/4.03.0/lib/base -I /home/travis/.opam/4.03.0/lib/base/caml -I /home/travis/.opam/4.03.0/lib/base/shadow_stdlib -I /home/travis/.opam/4.03.0/lib/base64 -I /home/travis/.opam/4.03.0/lib/bytes -I /home/travis/.opam/4.03.0/lib/fieldslib -I /home/travis/.opam/4.03.0/lib/ocaml -I /home/travis/.opam/4.03.0/lib/ppx_deriving -I /home/travis/.opam/4.03.0/lib/re -I /home/travis/.opam/4.03.0/lib/result -I /home/travis/.opam/4.03.0/lib/sexplib -I /home/travis/.opam/4.03.0/lib/sexplib/0 -I /home/travis/.opam/4.03.0/lib/stringext -I /home/travis/.opam/4.03.0/lib/uri -no-alias-deps -I cohttp/src -open Cohttp -o cohttp/src/cohttp__Link.cmx -c -impl cohttp/src/link.pp.ml)
�[33m# �[mFile "cohttp/src/link.ml", line 123, characters 10-11:
�[33m# �[mError: Multiple definition of the module name Fields.
�[33m# �[m       Names must be unique in a given structure or signature.
�[33m# �[m
�[33m# �[mWaiting for 1 job to finish.

Note sure what this means ...
All the datakit-ci issues are due to the constraint solver timing out.

@samoht
Copy link
Member Author

samoht commented Nov 22, 2017

Ha yes, the issue is ocaml-ppx/ppx_deriving#147

So I guess cohttp needs a lower bound on the ppx_deriving to use.

@hannesm
Copy link
Member

hannesm commented Nov 22, 2017

@samoht shouldn't instead the ppx_deriving versions which generate duplicated code have an available != 4.03.0? or is the issue only with deriving and cohttp?

@samoht
Copy link
Member Author

samoht commented Nov 22, 2017

@hannesm that's probably the right fix indeed!

@samoht
Copy link
Member Author

samoht commented Nov 22, 2017

I guess that's the same issue as #10807

@samoht
Copy link
Member Author

samoht commented Nov 23, 2017

Rebased on top of master to get the fix from #10807

@samoht samoht force-pushed the datakit branch 2 times, most recently from 09cce96 to cff633d Compare November 23, 2017 13:00
CHANGES:

- all: update to latest version of alcotest, conduit, session, ocaml-github,
  ocaml-github-hooks and cohttp (moby/datakit#612, @samoht and @djs55)

- github: make `User.t` abstract (moby/datakit#594, @samoht)
- github: turn `Webhook.events` into a promise (moby/datakit#598, @samoht)
- github: add a `Comment` module to model PR and issue comments (moby/datakit#595, @samoht)
- github: change `PR.owner` to be of type `User.t` (moby/datakit#599, @samoht)

- github-bridge: add the ability to sync PR's coments (moby/datakit#595, @samoht)

- go-client: handle large values when reading / writing in 9db (moby/datakit#292, @simonferquel)
- go-client: fix the handling of defaults over upgrade (moby/datakit#605, @djs55)
- go-client: improve transaction API (moby/datakit#606, @djs55)
@avsm avsm merged commit f676cc0 into ocaml:master Nov 23, 2017
@avsm
Copy link
Member

avsm commented Nov 23, 2017

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

@samoht samoht deleted the datakit branch April 12, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants