constrain ppx_deriving 4.2.1 to ocaml > 4.03.0 #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomimono
changed the title
✅ All lint checks passed 25d8a25
✅ Installability check (7787 → 7787) |
|
/cc @gasche ; I may have misunderstood something about what's included in 4.2.1 or the actual source of the code duplication, but it does appear to be happening with 4.2.1 still (see this build log for cohttp and ppx_deriving 4.2.1 on 4.03). |
|
Thanks, indeed I don't think 4.2.1 fixes this issue (I don't understand the issue but the discussion suggests that the problem lies with ppx_type_conv), so I believe that your fix is the right thing to do. Thanks! (This also supports the idea of indeed having a 4.1 maintenance release as I believe the non-driverized 4.1 does not suffer from the issue.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppx_deriving 4.2.1 is great to have released, but it does not contain a fix for ocaml-ppx/ppx_deriving#147 (duplicated code when using it with 4.03). ppx_deriving 4.2 is listed as available for OCaml > 4.03.0 because of this issue; propagate that to 4.2.1.