Encoding fixes and fixes for #195 and #224 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lincolnthree. Awesome to see you find some time to work on this! 🍻 I had a quick look at it. Actually this is pretty huge diff. So it is not easy to review. But actually we have a pretty good test suite covering encoding use cases. So if all tests are green, I'm very confident that the changes a fine. I'll merge this. We can do more fine tuning on master if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chkal Could you take a look at this and give me your thoughts? All tests passing, but I want to make sure that I have not done anything Crazy. I had to re-think the AddressBuilder a little bit. It was causing a lot of trouble to try to force decode and re-encode everything in the internal state, so I just made it represent whatever values were passed in, and make it clearer what would happen with the various parameters when they were provided via the builder API.