Enhance Managed Entity #1094
Merged
Enhance Managed Entity #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Agbabian <[email protected]>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
mikeradka
reviewed
May 23, 2024
pagbabian-splunk
added
enhancement
Signed-off-by: Paul Agbabian <[email protected]>
|
Looks pretty good to me. Once it is out of draft, I would be willing to re-review and approve. |
Signed-off-by: Paul Agbabian <[email protected]>
…ed_entity Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
mikeradka
approved these changes
May 29, 2024
cmcginley-splunk
approved these changes
May 29, 2024
zschmerber
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Managed Entity was too open ended, without enough detail on the changes to an arbitrary entity as a string value in
type. This PR adds specific object entities.Description of changes:
Added
type_id(along with existingtypeas sibling) with an initial set of types: Device, User, Group, Organization, Policy.Added to the constraints as
at_least_one