Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the entity management class #22

Merged
merged 2 commits into from
May 30, 2024
Merged

Enhance the entity management class #22

merged 2 commits into from
May 30, 2024

Conversation

mikeradka
Copy link
Contributor

@mikeradka mikeradka commented May 30, 2024 •
edited
Loading

This PR ports the OCSF Core enhancements to the Entity Management class:

  • Adds new activity_id's to the class
  • Adds type_id to the managed_entity object, along with device and email attributes.

Reference Core PRs:

image image

@mikeradka mikeradka self-assigned this May 30, 2024
@mikeradka mikeradka added enhancement New feature or request non-breaking labels May 30, 2024
cmcginley-splunk
cmcginley-splunk approved these changes May 30, 2024
View reviewed changes
events/audit/entity.json Outdated
}
},
"actor": {
"description": "Use for when the entity acting upon another entity is a process or user.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be left as is for parity with 1.x, but I'm guessing Use should be Used; maybe something to fix upstream the next time these files are touched

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Let me change it here since it is very straightforward, and I will put in a quick typo-fix PR on the upstream!

@mikeradka
Fix Typo in Desc
fc3acbc 
Signed-off-by: Michael Radka <[email protected]>
cmcginley-splunk
cmcginley-splunk approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@cmcginley-splunk cmcginley-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikeradka mikeradka merged commit f8ccd75 into main May 30, 2024
@mikeradka mikeradka deleted the SESA-1249/Enhance_Entity_Management_Class branch July 11, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcginley-splunk cmcginley-splunk cmcginley-splunk approved these changes

Assignees

@mikeradka mikeradka

Labels
enhancement New feature or request non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeradka @cmcginley-splunk