Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of geo location object #971

Merged
merged 6 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,22 @@ Thankyou! -->

### Added
* #### Objects
1. Added `auth_factor` object. #949
1. Added `auth_factor` object. #949

### Improved
* #### Event Classes
1. Added `auth_factors` array to Authentication event class. #949
1. Added `auth_factors` array to Authentication event class. #949
* #### Objects
1. Added `lat`, `long`, `geohash` attributes to `location` object. #971

### Bugfixes
1. Changed datatype of `priority` from `integer_t` to `string_t` #959

### Deprecated
1. Deprecated `coordinates` attrubute in favor of specific `lat`, `long` attributes. #971

### Misc
1. New Extension registration for Sedara. #951

<!-- All available sections in the Changelog:

Expand All @@ -44,13 +55,9 @@ Thankyou! -->
### Breaking changes

### Misc
1. New Extension registration for Sedara. #951

-->

### Bugfixes
1. Changed datatype of `priority` from `integer_t` to `string_t` #959

## [v1.1.0] - January 25th, 2024

### Added
Expand Down
19 changes: 19 additions & 0 deletions dictionary.json
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,10 @@
"type": "string_t"
},
"coordinates": {
"@deprecated": {
"message": "Use specific <code> lat, long </code> attributes instead.",
"since": "1.2.0"
},
"caption": "Coordinates",
"description": "A two-element array, containing a longitude/latitude pair. The format conforms with <a target='_blank' href='https://geojson.org'>GeoJSON</a>. For example: <code>[-73.983, 40.719]</code>.",
"is_array": true,
Expand Down Expand Up @@ -1717,6 +1721,11 @@
"description": "The entry-point function of the module. The system calls the entry-point function whenever a process or thread loads or unloads the module.",
"type": "string_t"
},
"geohash": {
"caption": "Geohash",
"description": "<p>Geohash of the geo-coordinates (latitude and longitude).</p><a target='_blank' href='https://en.wikipedia.org/wiki/Geohash'>Geohashing</a> is a geocoding system used to encode geographic coordinates in decimal degrees, to a single string.",
"type": "string_t"
},
"given_name": {
"caption": "Given Name",
"description": "The given or first name of the user.",
Expand Down Expand Up @@ -2164,6 +2173,11 @@
"description": "The most recent detection time of the activity or object. See specific usage.",
"type": "timestamp_t"
},
"lat": {
"caption": "Latitude",
"description": "The geographical Latitude coordinate represented in Decimal Degrees (DD). For example: <code>42.361145</code>.",
"type": "float_t"
},
"latency": {
"caption": "Latency",
"description": "The HTTP response latency measured in milliseconds.",
Expand Down Expand Up @@ -2339,6 +2353,11 @@
"sibling": "logon_type",
"type": "integer_t"
},
"long": {
"caption": "Longitude",
"description": "The geographical Longitude coordinate represented in Decimal Degrees (DD). For example: <code>-71.057083</code>.",
"type": "float_t"
},
"mac": {
"caption": "MAC Address",
"description": "The Media Access Control (MAC) address that is associated with the network interface.",
Expand Down
12 changes: 10 additions & 2 deletions objects/location.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"requirement": "recommended"
},
"coordinates": {
"requirement": "recommended"
"requirement": "optional"
},
"country": {
"requirement": "recommended"
Expand All @@ -21,12 +21,21 @@
"description": "The description of the geographical location.",
"requirement": "optional"
},
"geohash": {
floydtree marked this conversation as resolved.
Show resolved Hide resolved
"requirement": "optional"
},
"is_on_premises": {
"requirement": "optional"
},
"isp": {
"requirement": "optional"
},
"lat": {
"requirement": "optional"
},
"long": {
"requirement": "optional"
},
"postal_code": {
"requirement": "optional"
},
Expand All @@ -41,7 +50,6 @@
},
"constraints": {
"at_least_one": [
"coordinates",
"city",
"country",
"postal_code",
Expand Down
Loading