Repository Handler - always choose the same entity for latest when dates are equal #6887
Conversation
…tes are equal Signed-off-by: Alexandra Bucur <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -317,6 +319,18 @@ private EntityDetail getLatest(EntityDetail currentEntity, EntityDetail newEntit | |||
| newLastUpdate = newEntity.getCreateTime(); | |||
| } | |||
|
|
|||
| if(currentLastUpdate.equals(newLastUpdate)) | |||
There was a problem hiding this comment.
JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -317,6 +319,18 @@ private EntityDetail getLatest(EntityDetail currentEntity, EntityDetail newEntit | |||
| newLastUpdate = newEntity.getCreateTime(); | |||
| } | |||
|
|
|||
| if(currentLastUpdate.equals(newLastUpdate)) | |||
There was a problem hiding this comment.
UndefinedEquals: Date does not have well-defined equals behavior.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Alexandra Bucur [email protected]
Description
Two duplicate entities with equal effectivity dates were both retrieved. In order to choose always the same one I compared the GUIDs (the method is called for both; current and new entity parameters are alternatively each of the two).
Testing
Manually, searching entities with Asset Catalog